1199624 - Add missing cstring includes to security/pkix/lib/.

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Jacek Caban]

Attachment: fix

Those includes are needed on mingw for memcmp/memmove/memset functions since string include was removed from Char16.h.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8654039 [details] [diff] [review]
fix

Review of attachment 8654039 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.

I believe the patch for bug 1189891 broke this.

The proper fix needs to be consistent with the fix for bug 1189891: change the code to use std::equals and similar instead of mem*, and remove all #include <cstring>.

Comment 2

[Jacek Caban]

Attachment: fix

Thanks for the review. The attached patch avoids dependency on cstring.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8654502 [details] [diff] [review]
fix

Review of attachment 8654502 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Just one small issue.

::: security/pkix/lib/pkixnames.cpp
@@ +1700,5 @@
>            address + (2u * static_cast<size_t>(contractionIndex)),
>            componentsToMove * 2u);
>    // Fill in the contracted area with zeros.
> +  uint8_t* ptr = address + 2u * static_cast<size_t>(contractionIndex);
> +  std::fill(ptr, ptr + (8u - static_cast<size_t>(numComponents)) * 2u, 0u);

Please use std::fill_n here, without |ptr|.

Comment 4

[Jacek Caban]

Attachment: fix

Thanks. The attached version uses fill_n.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/982be1bbebdf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for Windows bustage.
https://treeherder.mozilla.org/logviewer.html#?job_id=13475943&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/889f8abb504e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Static analysis bustage too.
https://treeherder.mozilla.org/logviewer.html#?job_id=13475944&repo=mozilla-inbound

Comment 8

[Jacek Caban]

There was a typo, I pushed fixed version to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78c436350e59

Sorry about that.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3197d3b445b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a3197d3b445b