Closed Bug 1199625 Opened 5 years ago Closed 4 years ago

Test focus changing by long-tap for AccessibleCaretManager

Categories

(Core :: DOM: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We have bug 1197739 because there's no test to cover focus change from long-tap events fired by APZ. Specifically, the focus should not be changed unless AccessibleCaretManager is going to:

1) Dispatch CaretStateChangedEvent on an empty editable field.
2) Select a word on a selectable frame.

We should investigate whether we can write one per comment 
https://bugzilla.mozilla.org/show_bug.cgi?id=1197739#c10
Summary: Test focus changing by long-tap fired by for AccessibleCaretManager → Test focus changing by long-tap fired by APZ for AccessibleCaretManager
Assignee: nobody → tlin
Bug 1209841 was landed, so we can write such tests now.
Summary: Test focus changing by long-tap fired by APZ for AccessibleCaretManager → Test focus changing by long-tap for AccessibleCaretManager
Bug 1199625 - Test focus not being changed by long-pressing on non-selectable. r=mtseng

We already had focus changing tests covered by
_test_focus_obtained_by_long_press(). This patch adds tests for focus
not being changed from an editable element after long-pressing on a
non-selectable element.

These tests will fail after reverting this change.
"Bug 1197739 - Do not change focus too early unless the frame is selectable"
https://hg.mozilla.org/mozilla-central/rev/4f2822bbbdb2
Attachment #8673001 - Flags: review?(mtseng)
Attachment #8673001 - Flags: review?(mtseng) → review+
Comment on attachment 8673001 [details]
MozReview Request: Bug 1199625 - Test focus not being changed by long-pressing on non-selectable. r=mtseng

https://reviewboard.mozilla.org/r/21827/#review19589
Morris, thanks for the review.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2b2ec3e3090d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.