1199625 - Test focus changing by long-tap for AccessibleCaretManager

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We have bug 1197739 because there's no test to cover focus change from long-tap events fired by APZ. Specifically, the focus should not be changed unless AccessibleCaretManager is going to:

1) Dispatch CaretStateChangedEvent on an empty editable field.
2) Select a word on a selectable frame.

We should investigate whether we can write one per comment 
https://bugzilla.mozilla.org/show_bug.cgi?id=1197739#c10

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Bug 1209841 was landed, so we can write such tests now.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1199625 - Test focus not being changed by long-pressing on non-selectable. r=mtseng

Bug 1199625 - Test focus not being changed by long-pressing on non-selectable. r=mtseng

We already had focus changing tests covered by
_test_focus_obtained_by_long_press(). This patch adds tests for focus
not being changed from an editable element after long-pressing on a
non-selectable element.

These tests will fail after reverting this change.
"Bug 1197739 - Do not change focus too early unless the frame is selectable"
https://hg.mozilla.org/mozilla-central/rev/4f2822bbbdb2

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8673001 [details]
MozReview Request: Bug 1199625 - Test focus not being changed by long-pressing on non-selectable. r=mtseng

https://reviewboard.mozilla.org/r/21827/#review19589

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Morris, thanks for the review.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/2b2ec3e3090d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b2ec3e3090d