Update default browser detection in MigrationUtils.jsm for Edge

RESOLVED FIXED in Firefox 49

Status

()

defect
P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks 1 bug)

Trunk
Firefox 50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 wontfix, firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

(Whiteboard: [migration-needs-uplift])

Attachments

(1 attachment)

Assignee

Description

4 years ago
It seems the default browser detection gets "Launch Windows App" as the application description when Edge is selected as the default in Windows 10. For IE, it does correctly get "Internet Explorer".

I don't know if it's possible to fix the detection to produce something more explicit, but I'm also not too concerned about us misdetecting some kind of weird 3rd-party browser that is a windows app as Edge - given the current browser landscape it seems unlikely that that wouldn't be an Edge or IE clone, unless someone writes a blink wrapper as a universal windows app...

tl;dr: I think we should detect "Launch Windows App" as "Edge".

I also noticed that e.g. Nightly gets registered as, well, "Nightly". We could probably make sure that maps to firefox, too.
Assignee

Updated

3 years ago
Blocks: 1275114
Assignee

Updated

3 years ago
Blocks: 1276694
Attachment #8766474 - Flags: review?(dolske) → review+
Comment on attachment 8766474 [details]
Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection,

https://reviewboard.mozilla.org/r/61344/#review58212
(Gijs found that the weirdness in comment 0 was actually due to bug 1260483, so with that fix we can detect it as "Microsoft Edge", as one would expect.)
Depends on: 1260483

Comment 4

3 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/60999c6bc40a
recognize MS Edge in MigrationUtils.jsm for default browser detection, r=Dolske
Assignee

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/60999c6bc40a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee

Updated

3 years ago
Whiteboard: [migration-needs-uplift]
Assignee

Comment 6

3 years ago
Comment on attachment 8766474 [details]
Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection,

Approval Request Comment
[Feature/regressing bug #]: n/a - migration in general (both automatic and manual)
[User impact if declined]: on Windows 10, we do not correctly detect Edge as the default browser and do not preselect it in the migration dialog.
[Describe test coverage new/current, TreeHerder]: this was manually tested as part of the funnelcake work, on several different translations of Windows 10 to ensure it was robust. No automated testing is possible because Edge is Windows-10-specific and we still do not have infrastructure for windows 10 testing.
[Risks and why]: low risk - this change has ridden the 50 train without issue, was pretty thoroughly tested, and is really only a 1-line addition to the key-value pairs that we use to detect the default browser. This detection governs what browser is preselected in the "normal" profile migration dialog, and which browser the automatic migration (if turned on) tries to migrate data from.
[String/UUID change made/needed]: no.
Attachment #8766474 - Flags: approval-mozilla-beta?
Comment on attachment 8766474 [details]
Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection,

Support for automigration from Edge for funnelcake experiment in 49.
Attachment #8766474 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.