58 bytes, text/x-review-board-request
It seems the default browser detection gets "Launch Windows App" as the application description when Edge is selected as the default in Windows 10. For IE, it does correctly get "Internet Explorer". I don't know if it's possible to fix the detection to produce something more explicit, but I'm also not too concerned about us misdetecting some kind of weird 3rd-party browser that is a windows app as Edge - given the current browser landscape it seems unlikely that that wouldn't be an Edge or IE clone, unless someone writes a blink wrapper as a universal windows app... tl;dr: I think we should detect "Launch Windows App" as "Edge". I also noticed that e.g. Nightly gets registered as, well, "Nightly". We could probably make sure that maps to firefox, too.
Review commit: https://reviewboard.mozilla.org/r/61344/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61344/
Attachment #8766474 - Flags: review?(dolske)
Attachment #8766474 - Flags: review?(dolske) → review+
Comment on attachment 8766474 [details] Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection, https://reviewboard.mozilla.org/r/61344/#review58212
(Gijs found that the weirdness in comment 0 was actually due to bug 1260483, so with that fix we can detect it as "Microsoft Edge", as one would expect.)
Depends on: 1260483
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/60999c6bc40a recognize MS Edge in MigrationUtils.jsm for default browser detection, r=Dolske
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8766474 [details] Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection, Approval Request Comment [Feature/regressing bug #]: n/a - migration in general (both automatic and manual) [User impact if declined]: on Windows 10, we do not correctly detect Edge as the default browser and do not preselect it in the migration dialog. [Describe test coverage new/current, TreeHerder]: this was manually tested as part of the funnelcake work, on several different translations of Windows 10 to ensure it was robust. No automated testing is possible because Edge is Windows-10-specific and we still do not have infrastructure for windows 10 testing. [Risks and why]: low risk - this change has ridden the 50 train without issue, was pretty thoroughly tested, and is really only a 1-line addition to the key-value pairs that we use to detect the default browser. This detection governs what browser is preselected in the "normal" profile migration dialog, and which browser the automatic migration (if turned on) tries to migrate data from. [String/UUID change made/needed]: no.
Attachment #8766474 - Flags: approval-mozilla-beta?
Comment on attachment 8766474 [details] Bug 1199678 - recognize MS Edge in MigrationUtils.jsm for default browser detection, Support for automigration from Edge for funnelcake experiment in 49.
Attachment #8766474 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.