1199693 - Test CORS preflight interception with and without an internal redirect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Test CORS preflight interception with and without an internal redirect

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 8654171 [details] [diff] [review]
Test CORS preflight interception with and without an internal redirect

Review of attachment 8654171 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/fetch/fetch_tests.js
@@ +148,5 @@
>    my_ok(xhr.getResponseHeader("access-control-allow-origin") == null, "cors headers should be filtered out");
>    finish();
>  });
>  
> +// Test that CORS preflight requests cannot be intercepteda.

intercepted

@@ +149,5 @@
>    finish();
>  });
>  
> +// Test that CORS preflight requests cannot be intercepteda.
> +// This test happens with an internal redirect because the SW doesn't call respondWith.

I don't understand what this means, so let's be more explicit:
Performs a cross-origin XHR that the SW chooses not to intercept. This requires a preflight request, which the SW must not be allowed to intercept.

@@ +155,5 @@
>    my_ok(xhr.status == 0, "cross origin load with incorrect headers should be a failure");
>    finish();
>  }, [["X-Unsafe", "unsafe"]]);
>  
> +// Test that CORS preflight requests cannot be intercepteda.

intercepted

@@ +156,5 @@
>    finish();
>  }, [["X-Unsafe", "unsafe"]]);
>  
> +// Test that CORS preflight requests cannot be intercepteda.
> +// This test happens without an internal redirect because the SW does call respondWith.

Same confusion. More explicitly:
Performs a cross-origin XHR that the SW chooses to intercept and respond with a cross-origin fetch. This requires a preflight request, which the SW must not be allowed to intercept.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ba08e5e0857

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ba08e5e0857