I'll attach patches
Created attachment 8655012 [details] [diff] [review] bug1199745.patch not that familiar with treeherder code, this is just a guess
I think that's going to be too verbose in the UI (the longest strings we have for type is currently 5 characters. Also, could you submit as a pull request?
Also, could you update values.js and add a test? For examples, see: https://github.com/mozilla/treeherder/search?q=tsan&type=Code
Created attachment 8655624 [details] [review] PR #931: Allow treeherder to recognize add-on-devel builds Project that use both Bugzilla and GitHub typically use "paste text as attachment" feature to request review on the pull request, since it auto-redirects etc. See: https://ateam-bootcamp.readthedocs.org/en/latest/guide/development_process.html#git-and-github Creating that now.
Comment on attachment 8655624 [details] [review] PR #931: Allow treeherder to recognize add-on-devel builds Looks great, thank you :-) If you could squash + use a commit message containing the bug number/description, then comment in the bug, I'll merge this for you :-)
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/9263d8432642c2ca9f68b301250af0ffbec27d83 Bug 1199745 - Allow treeherder to recognize add-on-devel builds https://github.com/mozilla/treeherder/commit/b01ae805ef1eeebaa130e37e5ddf764d3932fde0 Merge pull request #932 from kmoir/master Bug 1199745 - Allow treeherder to recognize add-on-devel builds
Thank you - have merged :-) (If you're using OS X or Windows, I find SourceTree pretty useful for untangling git whoops moments: https://www.sourcetreeapp.com/) This will be in production at some point in the next week (see the "What's Deployed" link under the help menu in treeherder for a page showing what's queued for deploy) - if you need it sooner just shout :-)