Closed
Bug 1199745
Opened 9 years ago
Closed 9 years ago
Allow treeherder to recognize add-on-devel builds
Categories
(Tree Management :: Treeherder: Data Ingestion, defect)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kmoir, Assigned: kmoir)
References
Details
Attachments
(2 files, 1 obsolete file)
I'll attach patches
Assignee | ||
Updated•9 years ago
|
Summary: Allow treeherder to regcognize add-on-devel builds → Allow treeherder to recognize add-on-devel builds
Assignee | ||
Comment 1•9 years ago
|
||
not that familiar with treeherder code, this is just a guess
Comment 2•9 years ago
|
||
I think that's going to be too verbose in the UI (the longest strings we have for type is currently 5 characters. Also, could you submit as a pull request?
Updated•9 years ago
|
Assignee: nobody → kmoir
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Also, could you update values.js and add a test? For examples, see:
https://github.com/mozilla/treeherder/search?q=tsan&type=Code
Assignee | ||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Project that use both Bugzilla and GitHub typically use "paste text as attachment" feature to request review on the pull request, since it auto-redirects etc. See:
https://ateam-bootcamp.readthedocs.org/en/latest/guide/development_process.html#git-and-github
Creating that now.
Attachment #8655012 -
Attachment is obsolete: true
Attachment #8655624 -
Flags: review?(emorley)
Comment 6•9 years ago
|
||
Comment on attachment 8655624 [details] [review]
PR #931: Allow treeherder to recognize add-on-devel builds
Looks great, thank you :-)
If you could squash + use a commit message containing the bug number/description, then comment in the bug, I'll merge this for you :-)
Attachment #8655624 -
Flags: review?(emorley) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/9263d8432642c2ca9f68b301250af0ffbec27d83
Bug 1199745 - Allow treeherder to recognize add-on-devel builds
https://github.com/mozilla/treeherder/commit/b01ae805ef1eeebaa130e37e5ddf764d3932fde0
Merge pull request #932 from kmoir/master
Bug 1199745 - Allow treeherder to recognize add-on-devel builds
Comment 9•9 years ago
|
||
Thank you - have merged :-)
(If you're using OS X or Windows, I find SourceTree pretty useful for untangling git whoops moments: https://www.sourcetreeapp.com/)
This will be in production at some point in the next week (see the "What's Deployed" link under the help menu in treeherder for a page showing what's queued for deploy) - if you need it sooner just shout :-)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•