1199766 - Disable ICE TCP SO gathering

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Nils Ohlmeier [:drno]]

The only use case which ICE TCP SO candidates appear to be the useful for are SO connections over Turn, IF the Turn relay itself is behind a NAT.

So lets reduce the complexity for now and disable the gathering of SO candidates.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

https://reviewboard.mozilla.org/r/17653/#review15801

Comment 3

[Nils Ohlmeier [:drno]]

Looks like my attempt with a fancy new trychooser string was not super successful. Lets use a bigger hammer...

Comment 4

[Nils Ohlmeier [:drno]]

Try run looks green (except Android failures - which were too much for the test platform and have been disabled since).

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

Comment 6

[Nils Ohlmeier [:drno]]

If I'm mistaken I still need a review for adding something to libpref?!

Comment 7

[Benjamin Smedberg]

Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

https://reviewboard.mozilla.org/r/17653/#review16065

I don't need to review this: changes to default prefs belong to the module owners of those prefs, in general.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f590a95a2c64

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f590a95a2c64