Closed Bug 1199766 Opened 4 years ago Closed 4 years ago

Disable ICE TCP SO gathering

Categories

(Core :: WebRTC: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

The only use case which ICE TCP SO candidates appear to be the useful for are SO connections over Turn, IF the Turn relay itself is behind a NAT.

So lets reduce the complexity for now and disable the gathering of SO candidates.
Rank: 18
Priority: -- → P1
Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc
Attachment #8654323 - Flags: review?(ekr)
Attachment #8654323 - Flags: review?(docfaraday)
Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

https://reviewboard.mozilla.org/r/17653/#review15801
Attachment #8654323 - Flags: review?(docfaraday) → review+
Looks like my attempt with a fancy new trychooser string was not super successful. Lets use a bigger hammer...
Try run looks green (except Android failures - which were too much for the test platform and have been disabled since).
Keywords: checkin-needed
Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc
Attachment #8654323 - Flags: review?(ekr) → review?(benjamin)
If I'm mistaken I still need a review for adding something to libpref?!
Keywords: checkin-needed
Comment on attachment 8654323 [details]
MozReview Request: Bug 1199766: disbale ICE TCP SO gathering via user pref. r?ekr,r?bwc

https://reviewboard.mozilla.org/r/17653/#review16065

I don't need to review this: changes to default prefs belong to the module owners of those prefs, in general.
Attachment #8654323 - Flags: review?(benjamin)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f590a95a2c64
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.