1199808 - Fix Client build optimization settings

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Brian Nicholson (:bnicholson)]

Log shows this trying to debug:

Client was compiled with optimization - stepping may behave oddly; variables may not be available.

We should turn off optimization for Debug builds.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/990

Comment 2

[Richard Newman [:rnewman]]

Does this turn off optimization for release builds?

Also, IIRC we turned on whole-module optimization because the alternative is per-file, which is slower because of linking. Does this regress our build time?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Richard Newman [:rnewman] from comment #2)
> Does this turn off optimization for release builds?

No, WMO is still enabled for all non-Debug builds.

> Also, IIRC we turned on whole-module optimization because the alternative is
> per-file, which is slower because of linking. Does this regress our build
> time?

After doing a clean and build, build time seems about the same to me (~1 min for full build, with following incremental builds taking <5s).

Comment 4

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #3)
> for full build, with following incremental builds taking <5s).

Actually, this is quite a bit *faster* than before. I'm pretty sure incremental builds were taking 15+ seconds for me before.

Comment 5

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/e978a2cd7ada711954132cf5c5d2ad3f56af9d60