Closed Bug 1199842 Opened 6 years ago Closed 6 years ago

browserAction popup doesn't seem to work in Nightly

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: wbamberg, Assigned: billm)

References

Details

Attachments

(2 files)

Attached file borderify-button.xpi
I've attached a WebExtension that adds a browserAction with a popup attached. In my Nightly, the browserAction doesn't appear, and I see this in the console:

* [CustomizableUI] Custom widget with id borderify_mozilla_org-browser-action does not return a valid node CustomizableUI.jsm:166
* [CustomizableUI] Widget 'borderify_mozilla_org-browser-action' not found, unable to move CustomizableUI.jsm:166
* XUL_NS is not defined

In Chrome, the same extension works (if I remove the "applications" key from manifest.json). It works in Developer Edition as well (except that the popup is not resized to fit the content).
Attached patch patchSplinter Review
That bug just removed a variable. It turned out it was used in ext-browserActions.js, which pulls in all the vars of Extension.jsm.

The test for this isn't great, but it's enough to detect the bad behavior here. I'm going to ask about a better way to do this when more frontend people are around. I'm not too familiar with CustomizableUI.jsm.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #8654436 - Flags: review?(gkrizsanits)
Duplicate of this bug: 1200668
Attachment #8654436 - Flags: review?(gkrizsanits) → review+
Duplicate of this bug: 1201097
https://hg.mozilla.org/mozilla-central/rev/6ede4c1ffefd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.