1199842 - browserAction popup doesn't seem to work in Nightly

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Will Bamberg [:wbamberg]]

Attachment: borderify-button.xpi

I've attached a WebExtension that adds a browserAction with a popup attached. In my Nightly, the browserAction doesn't appear, and I see this in the console:

* [CustomizableUI] Custom widget with id borderify_mozilla_org-browser-action does not return a valid node CustomizableUI.jsm:166
* [CustomizableUI] Widget 'borderify_mozilla_org-browser-action' not found, unable to move CustomizableUI.jsm:166
* XUL_NS is not defined

In Chrome, the same extension works (if I remove the "applications" key from manifest.json). It works in Developer Edition as well (except that the popup is not resized to fit the content).

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This regressed in bug 1198970.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

That bug just removed a variable. It turned out it was used in ext-browserActions.js, which pulls in all the vars of Extension.jsm.

The test for this isn't great, but it's enough to detect the bad behavior here. I'm going to ask about a better way to do this when more frontend people are around. I'm not too familiar with CustomizableUI.jsm.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed8951e3f54

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3416308a1151 since one of this changes caused test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=13682808&repo=mozilla-inbound

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ede4c1ffefd

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ede4c1ffefd