Created attachment 8654417 [details] borderify-button.xpi I've attached a WebExtension that adds a browserAction with a popup attached. In my Nightly, the browserAction doesn't appear, and I see this in the console: * [CustomizableUI] Custom widget with id borderify_mozilla_org-browser-action does not return a valid node CustomizableUI.jsm:166 * [CustomizableUI] Widget 'borderify_mozilla_org-browser-action' not found, unable to move CustomizableUI.jsm:166 * XUL_NS is not defined In Chrome, the same extension works (if I remove the "applications" key from manifest.json). It works in Developer Edition as well (except that the popup is not resized to fit the content).
Created attachment 8654436 [details] [diff] [review] patch That bug just removed a variable. It turned out it was used in ext-browserActions.js, which pulls in all the vars of Extension.jsm. The test for this isn't great, but it's enough to detect the bad behavior here. I'm going to ask about a better way to do this when more frontend people are around. I'm not too familiar with CustomizableUI.jsm.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #8654436 - Flags: review?(gkrizsanits)
4 years ago
Duplicate of this bug: 1200668
Attachment #8654436 - Flags: review?(gkrizsanits) → review+
sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3416308a1151 since one of this changes caused test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=13682808&repo=mozilla-inbound
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.