1199872 - turning sound off in settings makes a sound

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dietrich Ayala (:dietrich)]

User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

In the sound sliders in the settings app, touching a slider immediately makes a sound. This is terrible if you are trying to ensure silence.

Also, it  is not necessary. You could only make the first sound at the next volume step in either direction.

This would accomplish what the user wants (know the sound at a *different* level than the current one) AND solves the silence scenario because we already handle the skipping of volume steps when the slider is moved quickly.

Comment 1

[Tiffanie Shakespeare [:tif]]

UX triage today:

The issue here is that there is a sound occurring on the first touch which is causing noise to happen when the user wants to quickly drag the slider to 0. 

We should eliminate the sound that occurs at first touch in addition to keep the current behaviour which is that slowly moving the slider will increase/decrease volume so the user can decide the right stopping point. Quickly sliding the slider to the 0 point will result in no noise. 

Thanks for pinging the UX team!

Comment 2

[[e-mail]]

Let me translate it to actionable treatments (hope I read it correctly):

* remove the sound at first touch
* Keep other current behavior

I can mentor and review it.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1199872-audio-turning-sound-off > mozilla-b2g:master

Comment 4

[Tiffanie Shakespeare [:tif]]

You got it Fred! Thanks so much for deciphering into action items :)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master

Comment 6

[Harly Hsu[:harly]]

Comment on attachment 8657697 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master

Looks good to me :)
Thank you Scott!

Comment 7

[[e-mail]]

Comment on attachment 8657697 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master

merged https://github.com/mozilla-b2g/gaia/commit/f37e8f732e0af961b43e912629c84c9e2ceda55d

thanks!

Comment 8

[Scott Wu [:scottwu]]

Thanks Fred and Harly!

Comment 9

[Dietrich Ayala (:dietrich)]

Awesome, thanks everyone! Excited to try this out in today's build.