All users were logged out of Bugzilla on October 13th, 2018

turning sound off in settings makes a sound

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dietrich, Assigned: scottwu, Mentored)

Tracking

({foxfood})

unspecified
foxfood

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [bzlite])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

In the sound sliders in the settings app, touching a slider immediately makes a sound. This is terrible if you are trying to ensure silence.

Also, it  is not necessary. You could only make the first sound at the next volume step in either direction.

This would accomplish what the user wants (know the sound at a *different* level than the current one) AND solves the silence scenario because we already handle the skipping of volume steps when the slider is moved quickly.
QA Whiteboard: [foxfood-triage]
Component: Gaia::Feedback → Gaia::System::Audio Mgmt
(Reporter)

Updated

3 years ago
Flags: needinfo?(firefoxos-ux-bugzilla)
UX triage today:

The issue here is that there is a sound occurring on the first touch which is causing noise to happen when the user wants to quickly drag the slider to 0. 

We should eliminate the sound that occurs at first touch in addition to keep the current behaviour which is that slowly moving the slider will increase/decrease volume so the user can decide the right stopping point. Quickly sliding the slider to the 0 point will result in no noise. 

Thanks for pinging the UX team!
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(gasolin)

Comment 2

3 years ago
Let me translate it to actionable treatments (hope I read it correctly):

* remove the sound at first touch
* Keep other current behavior

I can mentor and review it.
Mentor: gasolin
tracking-b2g: --- → backlog
Flags: needinfo?(gasolin)

Updated

3 years ago
Component: Gaia::System::Audio Mgmt → Gaia::Settings
(Assignee)

Updated

3 years ago
Assignee: nobody → scwwu
Created attachment 8657025 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off > mozilla-b2g:master
You got it Fred! Thanks so much for deciphering into action items :)
Created attachment 8657697 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8657025 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8657697 - Flags: review?(gasolin)
(Assignee)

Updated

3 years ago
Attachment #8657697 - Flags: ui-review?(hhsu)

Comment 6

3 years ago
Comment on attachment 8657697 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master

Looks good to me :)
Thank you Scott!
Attachment #8657697 - Flags: ui-review?(hhsu) → ui-review+

Comment 7

3 years ago
Comment on attachment 8657697 [details] [review]
[gaia] scottwu:1199872-audio-turning-sound-off-2 > mozilla-b2g:master

merged https://github.com/mozilla-b2g/gaia/commit/f37e8f732e0af961b43e912629c84c9e2ceda55d

thanks!
Attachment #8657697 - Flags: review?(gasolin) → review+

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

3 years ago
Thanks Fred and Harly!
(Reporter)

Comment 9

3 years ago
Awesome, thanks everyone! Excited to try this out in today's build.
You need to log in before you can comment on or make changes to this bug.