TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/unit/test_context_menu.js | xpcshell return code: 0

RESOLVED FIXED in Firefox 43

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Trunk
mozilla43
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
This is a NS_ERROR_FILE_NOT_FOUND on Cu.import("resource://gre/modules/LoginManagerContextMenu.jsm");
(Assignee)

Comment 2

3 years ago
It's not finding the file as it's browser-specific, cf. https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/components/passwordmgr/moz.build?offset=600#71.

Looks like test_context_menu.js should be skipped if CONFIG['MOZ_BUILD_APP'] != 'browser'.
Blocks: 433238
Flags: needinfo?(bernardo)
(Assignee)

Comment 3

3 years ago
I guess what's needed is a 
run-if = appname == "browser"
in the ini file.
(Assignee)

Comment 4

3 years ago
(In reply to aleth [:aleth] from comment #3)
> I guess what's needed is a 
> run-if = appname == "browser"
> in the ini file.

Sorry, buildapp, not appname, of course.
Feel free to submit a patch and I can review it.
If this is a browser-only test, maybe it would make sense to move the whole test to /browser?
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 12

3 years ago
Created attachment 8654835 [details] [diff] [review]
logincontext.diff
Attachment #8654835 - Flags: review?(MattN+bmo)
(Assignee)

Updated

3 years ago
Component: General → Password Manager
Product: Thunderbird → Toolkit
Comment on attachment 8654835 [details] [diff] [review]
logincontext.diff

Review of attachment 8654835 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8654835 - Flags: review?(MattN+bmo) → review+
Thank you for the patch, aleth.
Flags: needinfo?(bernardo)
(Assignee)

Updated

3 years ago
Keywords: intermittent-failure → checkin-needed
Assignee: nobody → aleth
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/72566e54e209
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* comm-beta: 9

Platform breakdown:
* windowsxp: 2
* osx-10-10: 2
* linux64: 2
* windows7-32: 1
* osx-10-6: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1199910&startday=2015-10-05&endday=2015-10-11&tree=all
You need to log in before you can comment on or make changes to this bug.