Closed
Bug 1199910
Opened 9 years ago
Closed 9 years ago
TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/unit/test_context_menu.js | xpcshell return code: 0
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file)
1.27 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
This is a NS_ERROR_FILE_NOT_FOUND on Cu.import("resource://gre/modules/LoginManagerContextMenu.jsm");
Assignee | ||
Comment 2•9 years ago
|
||
It's not finding the file as it's browser-specific, cf. https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/components/passwordmgr/moz.build?offset=600#71.
Looks like test_context_menu.js should be skipped if CONFIG['MOZ_BUILD_APP'] != 'browser'.
Blocks: 433238
Flags: needinfo?(bernardo)
Assignee | ||
Comment 3•9 years ago
|
||
I guess what's needed is a
run-if = appname == "browser"
in the ini file.
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to aleth [:aleth] from comment #3)
> I guess what's needed is a
> run-if = appname == "browser"
> in the ini file.
Sorry, buildapp, not appname, of course.
Comment 5•9 years ago
|
||
Feel free to submit a patch and I can review it.
Comment 6•9 years ago
|
||
If this is a browser-only test, maybe it would make sense to move the whole test to /browser?
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8654835 -
Flags: review?(MattN+bmo)
Assignee | ||
Updated•9 years ago
|
Component: General → Password Manager
Product: Thunderbird → Toolkit
Comment 13•9 years ago
|
||
Comment on attachment 8654835 [details] [diff] [review]
logincontext.diff
Review of attachment 8654835 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks
Attachment #8654835 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: intermittent-failure → checkin-needed
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 15•9 years ago
|
||
Keywords: checkin-needed
Comment 16•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•