Reconcile Title Case vs. Sentence case vs. Modified title Case in Treeherder and Perfherder

VERIFIED FIXED

Status

Tree Management
Treeherder
P5
trivial
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
wlach
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
So begat from a thread in bug 1199078 (our new Help menus), I had a look around at various platforms (Quora, Google, Facebook, etc) and although none are terribly consistent, there seems to be a general adoption of what I'd describe as "modified Title Case" for primary menus.

eg. where we have in our result set action menu

"Set as top of range"

we would use:

"Set as Top of Range"

Where articles like "the" "of" and "as" don't receive Title case, but pseudo proper-names (things that are key parts of the menu) or externally referenced services, do. Mozilla.org seems to be all over the map w.r.t. its use of Title Case, Modified title Case, and Sentence case.

Bootstrap's own site uses Sentence case, but they aren't dealing with the magnitude of proper names in menus (Talos, TreeStatus, HgStats, BuildAPI, Slave Health, etc) that we do.

If we went with Sentence case... I think the proliferation of 'Proper Names' described above would make Treeherder look predominantly modified Title Case anyway.

It would be nice for Treeherder to be internally consistent, so I'm posing the above 'modified Title Case approach', unless folks feel strongly we should use Sentence case.

As this will result in the maximum number of menus looking like each other.

If we agree on that, or whatever we agree on, I'll make the changes needed :)
(Assignee)

Updated

2 years ago
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
So let's try this for now, and adjust later if needed:

o top navbar menus - Title Case (generally what we have already)
o supporting menus (pinboard, resultset bar) - 'Sentence case' or 'Modified title case' per above, where it seems to make sense

There's only a few tweaks to be done with that logic.
(Assignee)

Comment 2

2 years ago
Created attachment 8661303 [details] [review]
PR 964

Tweak PR for review :)
Attachment #8661303 - Flags: review?(wlachance)
Comment on attachment 8661303 [details] [review]
PR 964

This all looks reasonable, thanks!
Attachment #8661303 - Flags: review?(wlachance) → review+
(Assignee)

Comment 5

2 years ago
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

2 years ago
Verified on production.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.