1200184 - [translate] Privileged users cannot make suggestions

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Currently suggestions from unprivileged users are marked as unapproved, but the privileged users cannot suggest any unapproved translation (or mark it as fuzzy/needs work/...). That would be very helpful for teams, which divides their responsibilities per project, e.g. Alice would like to suggest new translation in a project, which is Bob responsible for (and should approve the translation). But she cannot, as any change on Pontoon goes automatically to repos if Alice is privileged.

I think the privileged users should both:
1) be able to suggest new unapproved translations (the current translation, if any, will stay untouched in the repo)
2) and also to mark current translation as fuzzy.

Comment 1

[Matjaz Horvat [:mathjazz]]

Before I start working on this, I'd like to ask you for some feedback. I think there are (at least) two possible approaches:

1) Allow translators to submit suggestions or translations. We could add a setting similar to enabling/disabling quality checks, by which the user can switch if his submissions are made as suggestions or translations.

2) Add new category of submissions, e.g. "reviewed". Translators will still be unable to submit suggestions, but they could review translations other could review their translations.

Both of these approaches allow for easy filtering, in one case for suggestions and in the other for unreviewed translations. The main difference though is that translations, even if unreviewd, will end up in repository.

Which approach do you prefer?

Comment 2

[Francesco Lodolo [:flod]]

I think the important point about #2 is that translations end up in the product, and potentially in production, before being reviewed. That's probably something that should be avoided if a locale's workflow requires a review phase.

Given how quick the Quality checks is to switch on/off, I personally think that would be enough, as long as it's clear from the edit window that I'm suggesting and not storing translations (change the button label maybe?).

Comment 3

[Matjaz Horvat [:mathjazz]]

Yeah, in this case we should change the button label and color.

The reason I was thinking about 2) is because users with translator permissions should have enough skills and experience not to make to many mistakes.

Comment 4

[Gion-Andri Cantieni [:gion-andri]]

For us, both approaches would be ok. 

However, I would prefer the second one: I think, translator permissions should only be granted to persons that are experienced in contributing to that locale. This approach would allow getting the product completed even if the reviewer does not have time just then. I think, a localized product (with maybe some little mistakes or inconsistencies) is better than not have a localized product.

Comment 5

[Sara Todaro]

Thank you for addressing this bug, Matjaz, I really appreciate that :D

I'm personally leaning toward option 1 because it grants more control over what to send in production. This especially matters now that strings are committed automatically (instead of translators committing when they are ready, like on Verbatim).

Still, Gion-Andri makes a good point. It would be useful to have an option to mark strings that you want to send in production without delay but are still improvable.

In this regard, I noticed that among filtering options there is a "needswork" option.
How does it work? Can we enable that for marking strings that are somewhat adequate for going in production but could use some improvements?

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I would prefer the first one, or something like Verbatim does - during the translation, user can click a link which changes the Save button to Suggest.

The reason why I submitted this bug is, that Pontoon can translate everything - products and websites in one place, but we have divided responsibilities for projects in our team, so all of us who are experienced enough are privileged to be able to translate what we need to. That means we cannot make suggestions to each others projects, because they everything is approved automatically.

Per project privileges can solve our case, but speaking about privileged users suggestion, I would prefer the first option with possibility to switch between translations and suggestions during work instead of user profile/settings.

Comment 7

[Matjaz Horvat [:mathjazz]]

OK, seems like we're mostly in favour of the first option. It's also easier to implement. I'm taking it.

Gion-Andri,
We can still add the "reviewed" option later if we feel the need for it.

Sara,
"Needs work" is just a different expression for Fuzzy. So it only matters to Gettext (.po) projects. You can only remove "Needs work" flag by submitting a new approved translation or approving the existing one. We should either hide "Needs work" from non-Gettext projects or extend it to behave more like you and Michal suggested - add the ability for users to flag translation as "Needs work".

Michal, 
I can enable switching translations and suggestions from the profile menu (no need to leave the page), but I guess having that option right next to the Save button is even simpler. (In which case I should also move enabling/disabling quality checks somewhere in the editor, but that's a different thing).

Comment 8

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I did not noticed that option in the profile menu before. IMO that's a nice place for both.

Comment 9

[Sara Todaro]

(In reply to Matjaz Horvat [:mathjazz] from comment #7)
> Sara,
> "Needs work" is just a different expression for Fuzzy. So it only matters to
> Gettext (.po) projects. You can only remove "Needs work" flag by submitting
> a new approved translation or approving the existing one. We should either
> hide "Needs work" from non-Gettext projects or extend it to behave more like
> you and Michal suggested - add the ability for users to flag translation as
> "Needs work".

I see, so it's just for compatibility with the fuzzy option of po files. It would be nice in the future to be able to choose between fuzzies (for brand new translations) and suggestion (for inserting alternatives to existing translations) like we did on Verbatim. For the time being, though, I'm more than content with the implementation of just suggestions.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/0e5b5f295c65464967ecbec6cbedeeb50e1e0fa3
Fix bug 1200184: Allow translators to make suggestions

Uses different title (Suggest) and color (blue) for Save button if
user makes suggestions (either because they don't have translator
privileges or because they explicitly force to make suggestions in
preferences).

Other minor fixes:
* Remove obsolete user profile fields
* Fix notification loader position on translate page
* Make entire plural tab area clickable
* Fix unsaved changes warning when adding suggestions
* Check for unsaved changed when clicking Go button
* Fix Safari error with onpopstate event, triggered on first page load

https://github.com/mozilla/pontoon/commit/9538e9a5f3e2d554c50d0bc136ff84af09f421b4
Merge pull request #265 from mathjazz/bug-1200184-force-suggestions

Fix bug 1200184: Allow translators to make suggestions

Comment 11

[Matjaz Horvat [:mathjazz]]

I've just deployed the fix to produciton server.

You'll find a new "Make suggestions" setting in the profile menu and on the profile page. When enabled, Save button becomes blue, reads Suggest and (surprise!) submits suggestions instead of translations. When disabled, it becomes the good old green Save button again.

Please test and report any bugs here.