1200286 - The permissions section in user preferences should distinguish between assigned and inherited groups

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[Ed Morley [:emorley]]

When I visit https://bugzilla.mozilla.org/userprefs.cgi?tab=permissions I'm presented with a list of 54 groups.

Most of these are inherited due to me being in parent groups that contain them.

In order for me to understand where my various permissions come from (and so to ask what to remove if I no longer need it, or to know what to tell someone else when they say "I need the same permissions as you, what group should I ask for), it would be great to separate these out into <actual groups> and <inherited groups>.

eg:

"""
Direct member of:
everyone
mozilla-employee-confidential
security-release-team

Inherited member of:
firefox-core-security
...
"""

Comment 1

[:glob ✱]

basically we need to bring the logic/output from https://bugzilla.mozilla.org/page.cgi?id=group_membership.html&who=emorley%40mozilla.com%2C+&output=html to the permissions tab.

Comment 2

[David Lawrence [:dkl]]

Attachment: 1200286_1.patch

Comment 3

[:glob ✱]

Comment on attachment 8656069 [details] [diff] [review]
1200286_1.patch

Review of attachment 8656069 [details] [diff] [review]:
-----------------------------------------------------------------

::: skins/standard/admin.css
@@ +231,5 @@
>  }
>  
> +#permissions {
> +    min-width: 75%;
> +}

not sure what the goal of this min-width is.  it doesn't prevent the table from collapsing to a width which renders the data unreadable.

probably better off setting all columns except for the desc to nowrap, and set a min-width on just the desc column (don't use a %, something like 15em should do).

@@ +232,5 @@
>  
> +#permissions {
> +    min-width: 75%;
> +}
> +

the table cells need some horizontal padding - they run into each other currently.  suggestion: padding-right:1em

::: template/en/default/account/prefs/permissions.html.tmpl
@@ +37,5 @@
> +  <table border="0" cellspacing="0" id="permissions" class="hover">
> +    <tr>
> +      <th>Name</th>
> +      <th>Description</th>
> +      <th>Can Admin</th>

the 'can admin' column should only be shown to users who have admin bits, not everyone.

::: userprefs.cgi
@@ +460,5 @@
> +        } else {
> +            foreach my $g (@$ra_groups) {
> +                if ($g->id == $indirect_groups{$group->id}) {
> +                    $inherited = $g->name;
> +                    last;

i know this is a straight copy from existing code, but now's a good time to fix this - it's possible for someone to be a member of a group due to membership of multiple other groups.

bz_canusewhines is a good one to look at. this report is likely stating that you're in that group due to client-security-triage-team membership, but if you look at the group's config there are many groups that should all be listed.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Is this patch still viable?

Comment 5

[David Lawrence [:dkl]]

I still feel like this bug should be fixed even after all this time. I will update the patch and submit a proper pull request.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1200286 - The permissions section in user preferences should distinguish between assigned and inherited groups (#2268)

Comment 7

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/d76f2d47df4d9d04520908e42f35be335664e681