1200294 - we should get rid of minidump_stackwalk binaries in talos sources

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

Discussion about bug 787200 comment 55:

18:34 <@ted> parkouss: ok, so two things from that bug
18:34 <@ted> parkouss: 1) chmanchester is right, you don't really need to unify your talos.zip
18:35 <@ted> since it ought to be the same for each half of the build anyway
18:35 <@ted> but 2) talos should get rid of the minidump_stackwalk binary that's checked in and fetch one from tooltool like the unittest jobs do now
18:35 <jmaher> ted: good point; so many little changes needed to get this in-tree

Comment 1

[Julien Pagès (:parkouss)]

This might help me for the mozharness part:

19:13 <@ted> parkouss: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py#12 and https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py#261
19:13 <@ted> parkouss: and then this bit actually does the download: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/testbase.py?offset=0#630

Comment 2

[Julien Pagès (:parkouss)]

Attachment: 1200294.patch

Pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd08819e1c81

Note that we should see 'grabbing minidump binary from tooltool' in logs.

Comment 3

[Julien Pagès (:parkouss)]

Attachment: talos_1200294.patch

this is the talos side: removing minidump binaries from talos sources.

This now rely on the fact that mozcrash uses the env var MINIDUMP_STACKWALK:

https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/mozcrash/mozcrash.py#60

And this env var is defined by the previous mozharness patch.

Comment 4

[Julien Pagès (:parkouss)]

Comment on attachment 8655041 [details] [diff] [review]
1200294.patch

Removing the review flag for now, this is broken on try. I'll look at this later.

Comment 5

[Julien Pagès (:parkouss)]

Ok, so I figured out that I missed the tooltool.py executable in configuration. Just added it, and pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b03ee0cf2f9d

Comment 6

[Julien Pagès (:parkouss)]

Attachment: 1200294.patch

Ok, so far looks good now on try.

Also I tested locally with mach, still works (note that locally, no minidump will be generated though - we may address this later).

Note that this patch may conflict a bit with the one in bug 787200 (the run_local part). I'll rebase the patch once this one will be landed.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8655053 [details] [diff] [review]
talos_1200294.patch

Review of attachment 8655053 [details] [diff] [review]:
-----------------------------------------------------------------

I assume mozcrash will look in a predefined location?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8655324 [details] [diff] [review]
1200294.patch

Review of attachment 8655324 [details] [diff] [review]:
-----------------------------------------------------------------

the only problem I have here is that we don't have this for local runs.  To be honest most people didn't run with --symbols-path anyway which would have been required for this.  So overall this keeps us at parity!

Comment 9

[Julien Pagès (:parkouss)]

(In reply to Joel Maher (:jmaher) from comment #7)
> Comment on attachment 8655053 [details] [diff] [review]
> talos_1200294.patch
> 
> Review of attachment 8655053 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I assume mozcrash will look in a predefined location?

Yes, see comment 3.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6061c805b022

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6061c805b022

Comment 12

[Julien Pagès (:parkouss)]

Talos patch landed in https://hg.mozilla.org/build/talos/rev/be34538a5581.

Comment 13

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.