1200322 - Bad a11y when pressing Left and Right while the urlbar autocomplete popup is focused

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

1. Type something in the urlbar so that the popup opens with some results.
2. Press the Down arrow key to highlight any result.
3. Press the Left or Right arrow key so that the I-beam in the urlbar moves left or right.

Expected: Your screen reader should read the character under the I-beam as it moves left and right.

Actual: Your screen reader doesn't read anything.

Caused by bug 1174471, and it happens even when UnifiedComplete is disabled.  Commenting out the onKeyPress method in the urlbar binding fixes the problem: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml?rev=14733eceb2ed#189

Comment 1

[Drew Willcoxon :adw]

The search bar doesn't have the problem described in bug 1174471, interestingly.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch

This fixes the a11y problem and keeps the fix for bug 1174471 intact.  The problem seems to be not resetting selectedIndex.  That's what nsAutoCompleteController::ClosePopup does: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1117

ClosePopup is what bug 1174471's original fix was trying to emulate it looks like?  The call from this path here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp#589

Comment 3

[Drew Willcoxon :adw]

Attachment: patch v2

There should probably be a stopSearch call here too, since the path linked in comment 2 calls ClearSearchTimer before calling ClosePopup.  ClearSearchTimer and StopSearch aren't quite the same thing, but the latter calls the former.

Comment 4

[Drew Willcoxon :adw]

Attachment: patch v3

Here's an even simpler patch that just resets selectedIndex and then follows the usual nsAutoCompleteController path.  The crux of the problem is selectedIndex not being -1.

Sorry for the bugmail churn, Dave.

Comment 5

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/9f7bb8e84057

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f7bb8e84057

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8655000 [details] [diff] [review]
patch v3

Approval Request Comment
[Feature/regressing bug #]:
Bug 1174471 (landed on 41)

[User impact if declined]:
It will be difficult for people who use screen readers to use the urlbar.

[Describe test coverage new/current, TreeHerder]:
No new tests, urlbar is covered by existing tests, and I manually tested this on Aurora and Beta.

[Risks and why]:
Low risk, simple and well understood change.

[String/UUID change made/needed]:
None

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8655000 [details] [diff] [review]
patch v3

This seems like a very common scenario for accessibility users. Since the patch looks simple enough, let's uplift to Aurora42 and Beta41.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad5a99ae4493

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39f3fb013387