Closed Bug 1200336 Opened 4 years ago Closed 4 years ago

[e10s] Sandboxing doesn't work on a local build built with VS2015

Categories

(Core :: Security: Process Sandboxing, defect)

Unspecified
Windows
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla43
Tracking Status
e10s m8+ ---
firefox43 --- verified

People

(Reporter: JanH, Assigned: bobowen)

References

Details

Attachments

(1 file)

STR:
1. Build Firefox on Windows (I'm on Windows 7) with VS2015 and --enable-debug --disable-optimize.
2. mach run

What happens:
1. Firefox starts. Next, plugin-container.exe starts as well, but after a while exits again.
2. Because the plugin-container has gone AWOL, web browsing doesn't work: The tab title shows as "Connecting...", the tab throbber spins and the page itself remains white.

Setting security.sandbox.content.level to 0 gives the same results.
Completely disabling sandboxing by setting MOZ_DISABLE_CONTENT_SANDBOX=1 on the other hand fixes the symptoms - plugin-container.exe doesn't exit and browsing works.

Attaching the Visual Studio debugger while plugin-container.exe is alive gives me the following stack trace:
>    00182b50()
>    [Unten angegebene Rahmen sind möglicherweise nicht korrekt und/oder fehlen]	
>    [Externer Code]	
> -> plugin-container.exe!sandbox::TargetServicesBase::GetInstance() Zeile 102
>    plugin-container.exe!sandbox::SandboxFactory::GetTargetServices() Zeile 41
>    plugin-container.exe!TargetNtOpenThreadTokenEx(long (void *, unsigned long, unsigned char, unsigned long, void * *) * orig_OpenThreadTokenEx, void * thread, unsigned long desired_access, unsigned char open_as_self, unsigned long handle_attributes, void * * token) Zeile 120
>    [Externer Code]
Forgot to add, the error message is this one:
Ausnahmefehler bei 0x00182B50 in plugin-container.exe: 0xC0000005: Zugriffsverletzung beim Ausführen an Position 0x00182B50,
i.e. an access violation executing location 0x00182B50
Assignee: nobody → bobowen.code
tracking-e10s: --- → m8+
Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r?tabraldes
Attachment #8658577 - Flags: review?(tabraldes)
Blocks: vs2015
Comment on attachment 8658577 [details]
MozReview Request: Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r?tabraldes

https://reviewboard.mozilla.org/r/18665/#review16745

I think this is how to r+ now?
Attachment #8658577 - Flags: review?(tabraldes) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/da4d79a712c697a4aa1b671933648ef35ea310bb
Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r=tabraldes
https://hg.mozilla.org/mozilla-central/rev/da4d79a712c6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Verified on my local build, thanks for fixing this.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.