1200336 - [e10s] Sandboxing doesn't work on a local build built with VS2015

Status: VERIFIED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Jan Henning [:JanH]]

STR:
1. Build Firefox on Windows (I'm on Windows 7) with VS2015 and --enable-debug --disable-optimize.
2. mach run

What happens:
1. Firefox starts. Next, plugin-container.exe starts as well, but after a while exits again.
2. Because the plugin-container has gone AWOL, web browsing doesn't work: The tab title shows as "Connecting...", the tab throbber spins and the page itself remains white.

Setting security.sandbox.content.level to 0 gives the same results.
Completely disabling sandboxing by setting MOZ_DISABLE_CONTENT_SANDBOX=1 on the other hand fixes the symptoms - plugin-container.exe doesn't exit and browsing works.

Attaching the Visual Studio debugger while plugin-container.exe is alive gives me the following stack trace:
>    00182b50()
>    [Unten angegebene Rahmen sind möglicherweise nicht korrekt und/oder fehlen]	
>    [Externer Code]	
> -> plugin-container.exe!sandbox::TargetServicesBase::GetInstance() Zeile 102
>    plugin-container.exe!sandbox::SandboxFactory::GetTargetServices() Zeile 41
>    plugin-container.exe!TargetNtOpenThreadTokenEx(long (void *, unsigned long, unsigned char, unsigned long, void * *) * orig_OpenThreadTokenEx, void * thread, unsigned long desired_access, unsigned char open_as_self, unsigned long handle_attributes, void * * token) Zeile 120
>    [Externer Code]

Comment 1

[Jan Henning [:JanH]]

Forgot to add, the error message is this one:
Ausnahmefehler bei 0x00182B50 in plugin-container.exe: 0xC0000005: Zugriffsverletzung beim Ausführen an Position 0x00182B50,
i.e. an access violation executing location 0x00182B50

Comment 2

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8da53ca1e35f

Comment 3

[Bob Owen (:bobowen)]

Attachment: MozReview Request: Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r?tabraldes

Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r?tabraldes

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8658577 [details]
MozReview Request: Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r?tabraldes

https://reviewboard.mozilla.org/r/18665/#review16745

I think this is how to r+ now?

Comment 5

[Bob Owen (:bobowen)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da4d79a712c697a4aa1b671933648ef35ea310bb
Bug 1200336: Apply fix for Chromium issue 482784 for sandbox bug when built with VS2015. r=tabraldes

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da4d79a712c6

Comment 7

[Jan Henning [:JanH]]

Verified on my local build, thanks for fixing this.