1200381 - [Tab Audio Indicator] #context_toggleMuteTab menuitem does NOT have attribute for state

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150831030209

Steps to reproduce:

Confirm #context_toggleMuteTab menuitem attributes.


Actual results:

#context_toggleMuteTab menuitem does NOT have attribute for state. We can't know toggle state for adding context menu icon.


Expected results:

#context_toggleMuteTab menuitem should have attribute for state.

Comment 1

[(no longer active)]

Attachment: Enable themes to customize the appearance of the toggle mute tab context menu

This is done by setting the muted and soundplaying attributes on the
context menu item, similar to what has been done for the tab.

Comment 2

[magicp]

(In reply to Ehsan Akhgari (don't ask for review please) from comment #1)
> Created attachment 8655179 [details] [diff] [review]
> Enable themes to customize the appearance of the toggle mute tab context menu
> 
> This is done by setting the muted and soundplaying attributes on the
> context menu item, similar to what has been done for the tab.

Thank you for your fast decision!

Comment 3

[(no longer active)]

You're welcome!  :-)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f59a3e3b0f23

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f59a3e3b0f23

Comment 6

[magicp]

Does It apply in Firefox 42 ?

Comment 7

[(no longer active)]

Not yet, let me nominate it.

Comment 8

[(no longer active)]

Err, actually, this menu item is first introduced in 43, so it doesn't make sense to backport this patch to 42 since the menu item doesn't exist there.