1200400 - Add support for switchToShadowRoot in JSMarionette.

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now support for web components is only present in the Python client for Marionette. In order to be able to use it in JS we need the same level of support in JS client.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] yzen:bug-1200400 > mozilla-b2g:master

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Gareth, would you be able to take a look at this one? Gaia-components integration testing will be possible with this one. Also, let me know what needs to be done to update the version so it can be used externally from Gaia.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

I don't have a ton of free time at the moment, but I'll leave myself ni? for now so it's on my radar.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Ohh there's a patch!

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Would it be easy to add an integration test for this?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Gareth, took care of the tests. Could you take a look again?

Comment 7

[Martijn Wargers (dead)]

(In reply to Yura Zenevich [:yzen] from comment #0)
> Right now support for web components is only present in the Python client
> for Marionette. 

Oh, how can I make use of this from the python side of things?

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #7)
> (In reply to Yura Zenevich [:yzen] from comment #0)
> > Right now support for web components is only present in the Python client
> > for Marionette. 
> 
> Oh, how can I make use of this from the python side of things?

Python client already has switch_to_shadow_root since it's part of gecko, here are examples from tests:
https://github.com/mozilla/gecko-dev/commit/75c928c716a6e26162e42623db0cb60ccccf9c71#diff-413c9c7257267b3d931005d4dcdaaa84

Comment 9

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8655561 [details] [review]
[gaia] yzen:bug-1200400 > mozilla-b2g:master

Thanks for yet another nice patch yzen :)

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/b3f438d97d21f0f8f7d45ec4d7376978a3cb379a

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] gaye:1200400-marionette-client-v1.9.0 > mozilla-b2g:master

Comment 13

[Hubert Figuiere [:hub]]

Two questions: 

1. can we get the documentation updated? I'm using this one http://mozilla-b2g.github.io/marionette-js-client/api-docs/classes/Marionette.Client.html and it is not up to date

2. how do we restore the non shadow document root?