1200416 - [skiplist] Add nsTArray_Impl<.* to the skip list

Status: RESOLVED FIXED

(Socorro :: Backend, task)

Description

[Andrew McCreight [:mccr8]]

This is very generic, so it would be nice if we could also get the next frame in crash signatures.

Comment 1

[(Away)]

I haven't done the full archaeology, but I am going to assume based on [0] that the original intent was to prefix all nsTArray methods, and nsTArray_Impl came along at a later time.

So we should probably just add 'nsTArray_Impl<.*' or some equivalent.

[0] https://github.com/mozilla/socorro/blob/master/socorro/processor/signature_utilities.py#L437

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/4f105d4aba4a5f27f3302f0cd49f7d5fade5a1c6
Merge pull request #2970 from twobraids/nsTArray_Impl

fixes Bug 1200416 - added "nsTArray_Impl<.*" to prefix list
a daring selfie r+ and merge...

Comment 3

[K Lars Lohn [:lars] [:klohn]]

I have made this addition to the signature generation code.  When this change makes it to production, would you like the any of the existing crashes reprocessed?

Comment 4

[(Away)]

Unless Andrew disagrees, I think we can survive without reprocessing. For the current bug investigation there are enough new crashes coming in daily that we can just look at those.

Comment 5

[Andrew McCreight [:mccr8]]

Yeah, that should be fine. Thanks!

Comment 6

[K Lars Lohn [:lars] [:klohn]]

the change is currently running in Socorro staging.

in production (doesn't have the change), 4391a3b6-2171-4222-afd5-13ff12150831 has the signature "nsTArray_Impl<T>::AppendElement<T>"

in staging (with the change), 4391a3b6-2171-4222-afd5-13ff12150831 has the signature "nsTArray_Impl<T>::AppendElement<T> | nsCanvasFrame::CreateAnonymousContent"

Please confirm this effect that you wanted by adding "nsTArray_Impl<.*" to the prefix list.

Comment 7

[Andrew McCreight [:mccr8]]

Yes, that's good, thanks.