Closed
Bug 1200416
Opened 9 years ago
Closed 9 years ago
[skiplist] Add nsTArray_Impl<.* to the skip list
Categories
(Socorro :: Backend, task)
Socorro
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mccr8, Unassigned)
References
Details
This is very generic, so it would be nice if we could also get the next frame in crash signatures.
I haven't done the full archaeology, but I am going to assume based on [0] that the original intent was to prefix all nsTArray methods, and nsTArray_Impl came along at a later time. So we should probably just add 'nsTArray_Impl<.*' or some equivalent. [0] https://github.com/mozilla/socorro/blob/master/socorro/processor/signature_utilities.py#L437
Comment 2•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/4f105d4aba4a5f27f3302f0cd49f7d5fade5a1c6 Merge pull request #2970 from twobraids/nsTArray_Impl fixes Bug 1200416 - added "nsTArray_Impl<.*" to prefix list a daring selfie r+ and merge...
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 3•9 years ago
|
||
I have made this addition to the signature generation code. When this change makes it to production, would you like the any of the existing crashes reprocessed?
Unless Andrew disagrees, I think we can survive without reprocessing. For the current bug investigation there are enough new crashes coming in daily that we can just look at those.
Reporter | ||
Comment 5•9 years ago
|
||
Yeah, that should be fine. Thanks!
Comment 6•9 years ago
|
||
the change is currently running in Socorro staging. in production (doesn't have the change), 4391a3b6-2171-4222-afd5-13ff12150831 has the signature "nsTArray_Impl<T>::AppendElement<T>" in staging (with the change), 4391a3b6-2171-4222-afd5-13ff12150831 has the signature "nsTArray_Impl<T>::AppendElement<T> | nsCanvasFrame::CreateAnonymousContent" Please confirm this effect that you wanted by adding "nsTArray_Impl<.*" to the prefix list.
Reporter | ||
Comment 7•9 years ago
|
||
Yes, that's good, thanks.
Summary: [skiplist] Add nsTArray_Impl<T>::Clear() to the skip list → [skiplist] Add nsTArray_Impl<.* to the skip list
You need to log in
before you can comment on or make changes to this bug.
Description
•