Closed Bug 1200444 Opened 9 years ago Closed 9 years ago

JS::dbg::IsDebugger and JS::dbg::GetDebuggeeGlobals should see through CCWs

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

Make JS::dbg::{IsDebugger,GetDebuggeeGlobals} handle CCWs
4.25 KB, patch
jimb
: review+
Details | Diff | Splinter Review 
      No description provided.
Most devtools code that uses a Debugger actually ends up doing it through
modules with a different global from the one the Debugger was instantiated in,
and so it gets a CCW. When we pass one of these CCWs to
ThreadSafeChromeUtils.saveHeapSnapshot, it would throw NS_ERROR_INVALID_ARG. The
most straightforward fix is to have the JS APIs that
ThreadSafeChromeUtils.saveHeapSnapshot calls peek through CCWs.
Attachment #8655132 - Flags: review?(sphink)
Attachment #8655132 - Flags: review?(sphink) → review?(jimb)
Attachment #8655132 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/928ff2e0c463
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: