1200444 - JS::dbg::IsDebugger and JS::dbg::GetDebuggeeGlobals should see through CCWs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Make JS::dbg::{IsDebugger,GetDebuggeeGlobals} handle CCWs

Most devtools code that uses a Debugger actually ends up doing it through
modules with a different global from the one the Debugger was instantiated in,
and so it gets a CCW. When we pass one of these CCWs to
ThreadSafeChromeUtils.saveHeapSnapshot, it would throw NS_ERROR_INVALID_ARG. The
most straightforward fix is to have the JS APIs that
ThreadSafeChromeUtils.saveHeapSnapshot calls peek through CCWs.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5505a8f3df0

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/928ff2e0c463

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/928ff2e0c463