1200661 - Ticks overlap text and are on the wrong side for the RTL locales

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: nightly AR.png

43.0a1 (2015-09-01) Win 7

Steps:
1. Install http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/firefox-43.0a1.ar.win32.installer.exe
2. Start a new private window
3. Open about:privatebrowsing

Actual results:
Ticks overlap text and are on the wrong side - see attached

Comment 1

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Comment 2

[:Paolo Amadini]

I fixed the position of the mask as well, will update the commit message.

I'm not sure whether the tick has to be flipped on LTR but I guess this would need new assets since I didn't find a way to flip only the background image. This patch at least fixes the appearance.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

https://reviewboard.mozilla.org/r/18205/#review16293

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3cb68e7454d7

Comment 5

[Marco Mucci [:MarcoM]]

Hi Paolo, can you set this bug to either qe-verify+ or qe-verify-

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cb68e7454d7

Comment 7

[Paul Silaghi, QA [:pauly]]

Looks fine in 43.0a1 (2015-09-06) AR, FA, HE.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: about:privatebrowsing looks broken in RTL locales
[Describe test coverage new/current, TreeHerder]: QA verified the fix in nightly
[Risks and why]: Low risk, just additional CSS rules
[String/UUID change made/needed]: -

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Taking it as it is a new feature.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40c52f1db33e

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 42.0a2 (2015-09-09) AR, Win 7