Closed Bug 1200661 Opened 5 years ago Closed 5 years ago

Ticks overlap text and are on the wrong side for the RTL locales

Categories

(Firefox :: Private Browsing, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 43
Iteration:
43.2 - Sep 7
Tracking Status
firefox42 --- verified
firefox43 --- verified

People

(Reporter: pauly, Assigned: Paolo)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(2 files)

Attached image nightly AR.png
43.0a1 (2015-09-01) Win 7

Steps:
1. Install http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/firefox-43.0a1.ar.win32.installer.exe
2. Start a new private window
3. Open about:privatebrowsing

Actual results:
Ticks overlap text and are on the wrong side - see attached
Whiteboard: [fxprivacy] → [fxprivacy] [triage]
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert
Attachment #8656542 - Flags: review?(ttaubert)
I fixed the position of the mask as well, will update the commit message.

I'm not sure whether the tick has to be flipped on LTR but I guess this would need new assets since I didn't find a way to flip only the background image. This patch at least fixes the appearance.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 43.2 - Sep 7
Flags: qe-verify?
Blocks: 1188565
Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

https://reviewboard.mozilla.org/r/18205/#review16293
Attachment #8656542 - Flags: review?(ttaubert) → review+
Hi Paolo, can you set this bug to either qe-verify+ or qe-verify-
Flags: needinfo?(paolo.mozmail)
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(paolo.mozmail)
https://hg.mozilla.org/mozilla-central/rev/3cb68e7454d7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
QA Contact: paul.silaghi
Looks fine in 43.0a1 (2015-09-06) AR, FA, HE.
Status: RESOLVED → VERIFIED
Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: about:privatebrowsing looks broken in RTL locales
[Describe test coverage new/current, TreeHerder]: QA verified the fix in nightly
[Risks and why]: Low risk, just additional CSS rules
[String/UUID change made/needed]: -
Attachment #8656542 - Flags: approval-mozilla-aurora?
Comment on attachment 8656542 [details]
MozReview Request: Bug 1200661 - Ticks overlap text and are on the wrong side for the RTL locales. r=ttaubert

Taking it as it is a new feature.
Attachment #8656542 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Verified fixed FF 42.0a2 (2015-09-09) AR, Win 7
You need to log in before you can comment on or make changes to this bug.