Update SUMO URL and title for restricted profiles

VERIFIED FIXED in Firefox 42
(NeedInfo from)

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: barbara, Assigned: sebastian, NeedInfo)

Tracking

unspecified
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified, firefox43 verified, fennec42+)

Details

Attachments

(5 attachments)

Marketing/Communications/Legal/product would like to make sure that we don't use the name Kidfox anymore publicly (or at least say it's an internal name).

Could we please change the string "/kids" from the currently used URL for "Learn more" and change it to "/controlledaccess" 

e.g. https://support.mozilla.org/kb/kids  to https://support.mozilla.org/kb/controlledaccess

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1189920 for original bug request
tracking-fennec: --- → ?
Assignee: nobody → s.kaspari
Blocks: FFB, kidfox-v1
Status: NEW → ASSIGNED
Bug 1200665 - Restricted profiles: Update "learn more" URL on welcome panel. r?ally
Attachment #8655896 - Flags: review?(ally)
tracking-fennec: ? → 42+
Comment on attachment 8655896 [details]
MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally

https://reviewboard.mozilla.org/r/18039/#review16327

You'll also need to change it for the first run tiles and the bookmarks. Otherwise we're inconsistent in the product. http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/strings.xml.in#474  & https://dxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/chrome/region.properties
Attachment #8655896 - Flags: review?(ally)
Summary: Update to SUMO URL on restricted profile Splash screen (internally known as KidFox) → Update SUMO URL for restricted profiles
What's the status here? What's blocking this from landing?
Flags: needinfo?(s.kaspari)
Flags: needinfo?(ally)
(In reply to :Margaret Leibovic (PTO Aug 27 - Sept 14) from comment #3)
> What's the status here? What's blocking this from landing?

I'm on it. I'll upload a patch that also updates the tile and bookmark (I'm just back from vacation). :)
Flags: needinfo?(s.kaspari)
Flags: needinfo?(ally)
Barbara: As a heads-up: The title for this link (top sites / bookmarks) is: "Firefox Help and Support for a simplified kid-friendly version of Firefox". Not sure if you want to remove all "kid"-references. But it might be too late to change these strings anyways.
Flags: needinfo?(bbermes)
Comment on attachment 8655896 [details]
MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally

Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally
Attachment #8655896 - Attachment description: MozReview Request: Bug 1200665 - Restricted profiles: Update "learn more" URL on welcome panel. r?ally → MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally
Attachment #8655896 - Flags: review?(ally)
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Barbara: As a heads-up: The title for this link (top sites / bookmarks) is:
> "Firefox Help and Support for a simplified kid-friendly version of Firefox".
> Not sure if you want to remove all "kid"-references. But it might be too
> late to change these strings anyways.

Where do you see this written? Is this in your code? Can you show me a screenshot of it?

Thanks
Flags: needinfo?(bbermes) → needinfo?(s.kaspari)
Posted image bookmarks.png
Flags: needinfo?(s.kaspari)
Posted image topsites.png
I added two screenshots.
Flags: needinfo?(bbermes)
Sorry, just to confirm, is it definitely too late to change this due to the string freeze? 

I think we "have" to change the copy to family-friendly instead of kid-friendly (unless Matej or Comm wants something else).
Flags: needinfo?(matej)
Flags: needinfo?(mark.finkle)
Flags: needinfo?(bbermes)
Flags: needinfo?(ask)
The string in comment 5 is problematic for a couple of reasons: it says "kid-friendly," as Barbara mentions in comment 11, but it also refers to this as a version of Firefox, which it isn't. It should be something like this:

"Firefox Help and Support for restricted profiles on Android tablets"

We should make this change if at all possible. Thanks.
Flags: needinfo?(matej)
Summary: Update SUMO URL for restricted profiles → Update SUMO URL and title for restricted profiles
To clarify some details, this will only affect the suggested site in Fx42, since the default bookmark is only in Fx43. However, suggested site strings come from the region.properties file, which has its own special practices.

flod, what was the conclusion we reached here about the suggested site string? Would it be okay to uplift that change?
Flags: needinfo?(mark.finkle) → needinfo?(francesco.lodolo)
(In reply to :Margaret Leibovic from comment #13)
> flod, what was the conclusion we reached here about the suggested site
> string? Would it be okay to uplift that change?

Yes, uplifting the change to region.properties is OK, since we're asking localizers to not work on those keys and the change won't be reported by tools. You'll still need l10n=$release_driver_approving_uplift to work around the Mercurial hook.

As I wrote on IRC, we might have to rethink the strategy around these tiles since it looked like a temporary solution, but it's been around for a while now. For example having "locale-neuter" URLs in the en-US file, or moving description/titles into a localizable file. But that's argument for a different bug.
Flags: needinfo?(francesco.lodolo)
Great news! Thanks everyone, we'll be better next time in flagging this earlier.
Comment on attachment 8655896 [details]
MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally

https://reviewboard.mozilla.org/r/18039/#review17481

Drive-by reivew: this looks fine to me. Let's also get an aurora-specifc patch (patch without the bookmarks changes) that we can uplift. Let's also file a follow-up bug to come up with a better way to localize these suggested sites to address the concerns that flod has.
Attachment #8655896 - Flags: review+
Keywords: leave-open
Comment on attachment 8655896 [details]
MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally

I'll land this and create a new patch for the title + an aurora patch for both.
Attachment #8655896 - Flags: review?(ally)
Attachment #8662241 - Flags: review?(margaret.leibovic)
This is the modified patch for Aurora.
Attachment #8662300 - Flags: review?(margaret.leibovic)
Comment on attachment 8662241 [details] [diff] [review]
1200665-sumo-title.patch

Review of attachment 8662241 [details] [diff] [review]:
-----------------------------------------------------------------

Let's make sure the SUMO folks are in the loop about this change, since it would be good if the real page title at this URL matches this title.
Attachment #8662241 - Flags: review?(margaret.leibovic) → review+

Updated

4 years ago
Attachment #8662300 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8662300 [details] [diff] [review]
AURORA-1200665-sumo-title-url.patch

Approval Request Comment

[Feature/regressing bug #]: -

[User impact if declined]: Support top site uses wrong SUMO url and shows wrong/unwanted title. Support for restricted profiles is launching with Firefox 42.

[Describe test coverage new/current, TreeHerder]: Applied patch locally to aurora checkout and tested successfully.

[Risks and why]: Low, patch just changes title and url.

[String/UUID change made/needed]: Patch modifies mobile/locales/en-US/chrome/region.properties
Attachment #8662300 - Flags: approval-mozilla-aurora?
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/47f4d82b8129
https://hg.mozilla.org/mozilla-central/rev/b7653b40dc27
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment on attachment 8662300 [details] [diff] [review]
AURORA-1200665-sumo-title-url.patch

Sure, taking it.
Attachment #8662300 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
hm sebastian, seems this need l10n approval too:

i got:

remote: ************************** ERROR ****************************
remote: 
remote: * File used for localization (mobile/locales/en-US/chrome/region.properties) altered in this changeset *
remote: 
remote: This repository is string frozen. Please request explicit permission from
remote: release managers to break string freeze in your bug.
remote: If you have that explicit permission, denote that by including in
remote: your commit message l10n=...
remote: *************************************************************

when trying to push this
Flags: needinfo?(s.kaspari)
Discussed on IRC :)
Flags: needinfo?(s.kaspari)

Comment 30

4 years ago
Verified as fixed on both latest Nightly and Aurora builds.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.