Closed
Bug 1200665
Opened 9 years ago
Closed 9 years ago
Update SUMO URL and title for restricted profiles
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox42 verified, firefox43 verified, fennec42+)
VERIFIED
FIXED
Firefox 43
People
(Reporter: barbara, Assigned: sebastian, NeedInfo)
References
Details
Attachments
(5 files)
40 bytes,
text/x-review-board-request
|
Margaret
:
review+
|
Details |
101.50 KB,
image/png
|
Details | |
84.72 KB,
image/png
|
Details | |
4.25 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
2.66 KB,
patch
|
Margaret
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Marketing/Communications/Legal/product would like to make sure that we don't use the name Kidfox anymore publicly (or at least say it's an internal name). Could we please change the string "/kids" from the currently used URL for "Learn more" and change it to "/controlledaccess" e.g. https://support.mozilla.org/kb/kids to https://support.mozilla.org/kb/controlledaccess See also https://bugzilla.mozilla.org/show_bug.cgi?id=1189920 for original bug request
Reporter | ||
Updated•9 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1200665 - Restricted profiles: Update "learn more" URL on welcome panel. r?ally
Attachment #8655896 -
Flags: review?(ally)
Updated•9 years ago
|
tracking-fennec: ? → 42+
Comment 2•9 years ago
|
||
Comment on attachment 8655896 [details] MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally https://reviewboard.mozilla.org/r/18039/#review16327 You'll also need to change it for the first run tiles and the bookmarks. Otherwise we're inconsistent in the product. http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/strings.xml.in#474 & https://dxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/chrome/region.properties
Attachment #8655896 -
Flags: review?(ally)
Assignee | ||
Updated•9 years ago
|
Summary: Update to SUMO URL on restricted profile Splash screen (internally known as KidFox) → Update SUMO URL for restricted profiles
Comment 3•9 years ago
|
||
What's the status here? What's blocking this from landing?
Flags: needinfo?(s.kaspari)
Flags: needinfo?(ally)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to :Margaret Leibovic (PTO Aug 27 - Sept 14) from comment #3) > What's the status here? What's blocking this from landing? I'm on it. I'll upload a patch that also updates the tile and bookmark (I'm just back from vacation). :)
Flags: needinfo?(s.kaspari)
Flags: needinfo?(ally)
Assignee | ||
Comment 5•9 years ago
|
||
Barbara: As a heads-up: The title for this link (top sites / bookmarks) is: "Firefox Help and Support for a simplified kid-friendly version of Firefox". Not sure if you want to remove all "kid"-references. But it might be too late to change these strings anyways.
Flags: needinfo?(bbermes)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8655896 [details] MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally
Attachment #8655896 -
Attachment description: MozReview Request: Bug 1200665 - Restricted profiles: Update "learn more" URL on welcome panel. r?ally → MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally
Attachment #8655896 -
Flags: review?(ally)
Reporter | ||
Comment 7•9 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #5) > Barbara: As a heads-up: The title for this link (top sites / bookmarks) is: > "Firefox Help and Support for a simplified kid-friendly version of Firefox". > Not sure if you want to remove all "kid"-references. But it might be too > late to change these strings anyways. Where do you see this written? Is this in your code? Can you show me a screenshot of it? Thanks
Flags: needinfo?(bbermes) → needinfo?(s.kaspari)
Assignee | ||
Comment 8•9 years ago
|
||
Flags: needinfo?(s.kaspari)
Assignee | ||
Comment 9•9 years ago
|
||
Reporter | ||
Comment 11•9 years ago
|
||
Sorry, just to confirm, is it definitely too late to change this due to the string freeze? I think we "have" to change the copy to family-friendly instead of kid-friendly (unless Matej or Comm wants something else).
Flags: needinfo?(matej)
Flags: needinfo?(mark.finkle)
Flags: needinfo?(bbermes)
Flags: needinfo?(ask)
Comment 12•9 years ago
|
||
The string in comment 5 is problematic for a couple of reasons: it says "kid-friendly," as Barbara mentions in comment 11, but it also refers to this as a version of Firefox, which it isn't. It should be something like this: "Firefox Help and Support for restricted profiles on Android tablets" We should make this change if at all possible. Thanks.
Flags: needinfo?(matej)
Assignee | ||
Updated•9 years ago
|
Summary: Update SUMO URL for restricted profiles → Update SUMO URL and title for restricted profiles
Comment 13•9 years ago
|
||
To clarify some details, this will only affect the suggested site in Fx42, since the default bookmark is only in Fx43. However, suggested site strings come from the region.properties file, which has its own special practices. flod, what was the conclusion we reached here about the suggested site string? Would it be okay to uplift that change?
Flags: needinfo?(mark.finkle) → needinfo?(francesco.lodolo)
Comment 14•9 years ago
|
||
(In reply to :Margaret Leibovic from comment #13) > flod, what was the conclusion we reached here about the suggested site > string? Would it be okay to uplift that change? Yes, uplifting the change to region.properties is OK, since we're asking localizers to not work on those keys and the change won't be reported by tools. You'll still need l10n=$release_driver_approving_uplift to work around the Mercurial hook. As I wrote on IRC, we might have to rethink the strategy around these tiles since it looked like a temporary solution, but it's been around for a while now. For example having "locale-neuter" URLs in the en-US file, or moving description/titles into a localizable file. But that's argument for a different bug.
Flags: needinfo?(francesco.lodolo)
Comment 15•9 years ago
|
||
Cross checked with https://transvision.mozfr.org/string/?entity=mobile/chrome/region.properties:browser.suggestedsites.restricted_fxsupport.url&repo=aurora, we should be good to just adjust that url to what we want it to be.
Reporter | ||
Comment 16•9 years ago
|
||
Great news! Thanks everyone, we'll be better next time in flagging this earlier.
Comment 17•9 years ago
|
||
Comment on attachment 8655896 [details] MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally https://reviewboard.mozilla.org/r/18039/#review17481 Drive-by reivew: this looks fine to me. Let's also get an aurora-specifc patch (patch without the bookmarks changes) that we can uplift. Let's also file a follow-up bug to come up with a better way to localize these suggested sites to address the concerns that flod has.
Attachment #8655896 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8655896 [details] MozReview Request: Bug 1200665 - Restricted profiles: Update SUMO URL. r?ally I'll land this and create a new patch for the title + an aurora patch for both.
Attachment #8655896 -
Flags: review?(ally)
Assignee | ||
Comment 20•9 years ago
|
||
Attachment #8662241 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 21•9 years ago
|
||
This is the modified patch for Aurora.
Attachment #8662300 -
Flags: review?(margaret.leibovic)
Comment 22•9 years ago
|
||
Comment on attachment 8662241 [details] [diff] [review] 1200665-sumo-title.patch Review of attachment 8662241 [details] [diff] [review]: ----------------------------------------------------------------- Let's make sure the SUMO folks are in the loop about this change, since it would be good if the real page title at this URL matches this title.
Attachment #8662241 -
Flags: review?(margaret.leibovic) → review+
Updated•9 years ago
|
Attachment #8662300 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 23•9 years ago
|
||
Comment on attachment 8662300 [details] [diff] [review] AURORA-1200665-sumo-title-url.patch Approval Request Comment [Feature/regressing bug #]: - [User impact if declined]: Support top site uses wrong SUMO url and shows wrong/unwanted title. Support for restricted profiles is launching with Firefox 42. [Describe test coverage new/current, TreeHerder]: Applied patch locally to aurora checkout and tested successfully. [Risks and why]: Low, patch just changes title and url. [String/UUID change made/needed]: Patch modifies mobile/locales/en-US/chrome/region.properties
Attachment #8662300 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/47f4d82b8129 https://hg.mozilla.org/mozilla-central/rev/b7653b40dc27
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 26•9 years ago
|
||
Comment on attachment 8662300 [details] [diff] [review] AURORA-1200665-sumo-title-url.patch Sure, taking it.
Attachment #8662300 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 27•9 years ago
|
||
hm sebastian, seems this need l10n approval too: i got: remote: ************************** ERROR **************************** remote: remote: * File used for localization (mobile/locales/en-US/chrome/region.properties) altered in this changeset * remote: remote: This repository is string frozen. Please request explicit permission from remote: release managers to break string freeze in your bug. remote: If you have that explicit permission, denote that by including in remote: your commit message l10n=... remote: ************************************************************* when trying to push this
Flags: needinfo?(s.kaspari)
Comment 28•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ad6f3877d92
status-firefox42:
--- → fixed
Comment 30•9 years ago
|
||
Verified as fixed on both latest Nightly and Aurora builds.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•