Closed
Bug 1200782
Opened 9 years ago
Closed 9 years ago
Inline Array.isArray
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
6.16 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
This patch inlines Array.isArray when we know the result statically. Combined with (scripted function) inlining this will hopefully cover the most common cases.
Array.isArray is used extensively by jQuery and lodash.
Babel uses it for destructuring (see http://kpdecker.github.io/six-speed/, note that babel-loose doesn't use isArray). A micro-benchmark based on that test improves from 1000 ms to 30 ms.
Attachment #8655602 -
Flags: review?(bhackett1024)
|
||
Updated•9 years ago
|
Attachment #8655602 -
Flags: review?(bhackett1024) → review+
|
||
Comment 2•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•