1200825 - Relax the driver crash guard in a few scenarios

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

For nightly testing, having the crash guard means you're more likely to lose acceleration, which is annoying. In addition we think it's okay for WebGL to not be crash guarded in content processes, since this makes it easier to test/debug, and also lessens the risk of losing WebGL activation.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8655658 [details] [diff] [review]
fix

Review of attachment 8655658 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/DriverCrashGuard.cpp
@@ +57,5 @@
>  {
> +  // We only use the crash guard on non-nightly channels, since the nightly
> +  // channel is for development and having graphics features perma-disabled
> +  // is rather annoying.
> +#if !defined(NIGHTLY_BUILD)

This would be nicer as an early-out, instead of having to enclose the whole block.

Also prefer #ifndef.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

Add an env var to disable crash guards as well.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8655759 [details] [diff] [review]
v2

Review of attachment 8655759 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/DriverCrashGuard.cpp
@@ +74,5 @@
> +  static bool sEnvChecked = false;
> +  static bool sAllGuardsDisabled = false;
> +  if (!sEnvChecked) {
> +    sAllGuardsDisabled = !!PR_GetEnv("MOZ_DISABLE_CRASH_GUARD");
> +    sEnvChecked = true;

The way statics work, I believe you should be able to just do:
static bool sAllGuardsDisabled = !!PR_GetEnv("MOZ_DISABLE_CRASH_GUARD");

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d80ccfc9a7d8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d80ccfc9a7d8