1200937 - APN Settings: support reading 'mtu' field from apn database

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Some carries' apn provide a mtu value, specially those that support IPv6. RIL need this value to be able to set the interface mtu correctly.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jessi3py:bug-1200937 > mozilla-b2g:master

Comment 2

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8662787 [details] [review]
[gaia] jessi3py:bug-1200937 > mozilla-b2g:master

Hi Fred, I am not that familiar with gaia code, so I just grep around to see what needs to be changed. I tested manually and it seems to work fine. Would you mind reviewing it? Thanks.

Comment 3

[[e-mail]]

Comment on attachment 8662787 [details] [review]
[gaia] jessi3py:bug-1200937 > mozilla-b2g:master

Thanks for providing the patch! Please add missing test lines based on comments on github, then set review again.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8662787 [details] [review]
[gaia] jessi3py:bug-1200937 > mozilla-b2g:master

Hi Fred, I have updated the patch on github. The new patch adds test lines for mtu and also tests for fota apn type, which were missing before.
As per discussed, let's fix operator_variant_handler_test in bug 1206623. Thanks!

Comment 5

[[e-mail]]

merged merged https://github.com/mozilla-b2g/gaia/commit/c8eb5b259873fda309a74507aad5f0823fda2591

thanks!