Closed
Bug 1201007
Opened 9 years ago
Closed 9 years ago
[B2G] Enable mono audio setting option in Gaia
Categories
(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)
Firefox OS Graveyard
Gaia::System::Accessibility
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S8 (02Oct)
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file)
This feature is to be provide for someone who has full hearing loss in one ear.
With this option, they will have both channels mixed so they can get the full sound with one ear.
See bug1175447 for more details.
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8655909 [details] [review]
[gaia] alastor0325:bug1175447_monoAudio > mozilla-b2g:master
Hi, Eitan,
Sorry to bother you,
Could you help me review this patch?
This patch is to implement the enable option for the mono audio setting in the Settings::Accessibility.
Very appreciate :)
Attachment #8655909 -
Flags: review?(eitan)
Comment 3•9 years ago
|
||
Comment on attachment 8655909 [details] [review]
[gaia] alastor0325:bug1175447_monoAudio > mozilla-b2g:master
Forwarding the review to yura, since he is a settings app peer AND and a11y engineer.
Attachment #8655909 -
Flags: review?(eitan) → review?(yzenevich)
Comment 4•9 years ago
|
||
Comment on attachment 8655909 [details] [review]
[gaia] alastor0325:bug1175447_monoAudio > mozilla-b2g:master
Just a couple of comments (mainly nits) and could you also add a unit test for that panel, since you touched some JavaScript. Thanks!
Attachment #8655909 -
Flags: review?(yzenevich)
Comment 5•9 years ago
|
||
Flag me for r? once I can take a look again
Assignee | ||
Comment 6•9 years ago
|
||
Hi, Yura,
Because I'm not familiar with the Gaia unit test, could you give me some references?
Or give me some suggestion what should I test for pacth?
In addition, after changing the back button localized [1], I found that the header text would deviate the middle. The text can't keep in the middle of the page, do you know why?
Very appreciate!
[1] https://github.com/gaia-components/gaia-header#localization
Flags: needinfo?(yzenevich)
Comment 7•9 years ago
|
||
Hi Alastor, here are some details:
* General info about the gaia unit tests is here (how to run them locally, etc) :
https://developer.mozilla.org/en-US/Firefox_OS/Automated_testing/Gaia_unit_tests
* Some good examples that you can use as a template for your panel unit test are here (apps/settings/test/unit/panels/accessibility/pabel_test.js is what you'd need to create):
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/unit/panels/achievements/panel_test.js
You would just need to test the js logic that you added which is enabled/disabled description updating on setting change.
Flags: needinfo?(yzenevich)
Comment 8•9 years ago
|
||
It looks like a bug in gaia-header. I will file it, feel free to remove the l10n part for now. Thanks.
Assignee | ||
Comment 9•9 years ago
|
||
Hi, Yura,
Could you help me review again?
Since the accessibility/panel.js only has onInit function, I only test the panel initialization in the panel_test.js.
Very appreciate!
Flags: needinfo?(yzenevich)
Comment 10•9 years ago
|
||
(In reply to Alastor Wu [:alwu] from comment #9)
> Hi, Yura,
> Could you help me review again?
>
> Since the accessibility/panel.js only has onInit function, I only test the
> panel initialization in the panel_test.js.
>
> Very appreciate!
Looks good, Alastor. Just 2 nits and one string disambiguation comment. Feel free to r? me after you make those changes. Thanks for doing it btw!
Flags: needinfo?(yzenevich)
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8655909 [details] [review]
[gaia] alastor0325:bug1175447_monoAudio > mozilla-b2g:master
Hi, Yura,
I've modified my patch, could you help me review it again?
Very appreciate :)
Attachment #8655909 -
Flags: review?(yzenevich)
Comment 12•9 years ago
|
||
Comment on attachment 8655909 [details] [review]
[gaia] alastor0325:bug1175447_monoAudio > mozilla-b2g:master
Looks good, just one final nit to address and it's good to go. Thanks!
Attachment #8655909 -
Flags: review?(yzenevich) → review+
Comment 14•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•