Closed Bug 1201031 Opened 4 years ago Closed 4 years ago

Menu for conversation options in the panel should be under the arrow

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Iteration:
43.2 - Sep 7
Tracking Status
firefox43 --- fixed

People

(Reporter: standard8, Assigned: Mardak)

References

Details

(Whiteboard: [visual refresh])

Attachments

(2 files)

Using the new menu for conversation options in the panel, the first time I clicked the arrow, then moved the mouse down vertically, at which point the menu went away.

I think we should position the menu so that it is definitely underneath the arrow so that its less likely the user misses it.
Flags: firefox-backlog+
Rank: 16
Attached image right: 0px, 2rem, 21px
Any particular menu position to go with or a different one?
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8656679 - Flags: ui-review?(sfranks)
Comment on attachment 8656679 [details]
right: 0px, 2rem, 21px

(In reply to Ed Lee :Mardak from comment #1)
> Created attachment 8656679 [details]
> right: 0px, 2rem, 21px
> 
> Any particular menu position to go with or a different one?

21px looks better aligned with the right-edge of the button. Let's go with that one. Thanks!
Attachment #8656679 - Flags: ui-review?(sfranks) → ui-review+
The current 45px came from bug 1183642.

andreio, do you remember where you got that number?
Depends on: 1183642
Attached patch v1Splinter Review
Attachment #8656696 - Flags: review?(andrei.br92)
Comment on attachment 8656696 [details] [diff] [review]
v1

Review of attachment 8656696 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this.
Attachment #8656696 - Flags: review?(andrei.br92) → review+
https://hg.mozilla.org/integration/fx-team/rev/518ebf581a90fb932279d574d5e4239aee25a182
Bug 1201031 - Menu for conversation options in the panel should be under the arrow [r=andreio]
https://hg.mozilla.org/mozilla-central/rev/518ebf581a90
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
This got regressed by bug 1192372. I'll reland the patch.
Depends on: 1192372
https://hg.mozilla.org/integration/fx-team/rev/1b51d0c353153f42c62b4e4ef6ca10fcd93c6f69
Bug 1201031 - Menu for conversation options in the panel should be under the arrow [r=andreio]
Iteration: --- → 43.2 - Sep 7
You need to log in before you can comment on or make changes to this bug.