Closed
Bug 1201031
Opened 9 years ago
Closed 9 years ago
Menu for conversation options in the panel should be under the arrow
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: standard8, Assigned: Mardak)
References
Details
(Whiteboard: [visual refresh])
Attachments
(2 files)
|
267.46 KB,
image/png
|
sevaan
:
ui-review+
|
Details |
|
1.24 KB,
patch
|
andreio
:
review+
|
Details | Diff | Splinter Review |
right: 0px, 2rem, 21px
Using the new menu for conversation options in the panel, the first time I clicked the arrow, then moved the mouse down vertically, at which point the menu went away. I think we should position the menu so that it is definitely underneath the arrow so that its less likely the user misses it.
Flags: firefox-backlog+
|
Reporter | |
Updated•9 years ago
|
Rank: 16
|
Assignee | |
Comment 1•9 years ago
|
||
Any particular menu position to go with or a different one?
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8656679 [details] right: 0px, 2rem, 21px (In reply to Ed Lee :Mardak from comment #1) > Created attachment 8656679 [details] > right: 0px, 2rem, 21px > > Any particular menu position to go with or a different one? 21px looks better aligned with the right-edge of the button. Let's go with that one. Thanks!
Attachment #8656679 -
Flags: ui-review?(sfranks) → ui-review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
The current 45px came from bug 1183642. andreio, do you remember where you got that number?
Depends on: 1183642
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8656696 -
Flags: review?(andrei.br92)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8656696 [details] [diff] [review] v1 Review of attachment 8656696 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this.
Attachment #8656696 -
Flags: review?(andrei.br92) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/518ebf581a90fb932279d574d5e4239aee25a182 Bug 1201031 - Menu for conversation options in the panel should be under the arrow [r=andreio]
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/518ebf581a90
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
|
Assignee | |
Comment 8•9 years ago
|
||
This got regressed by bug 1192372. I'll reland the patch.
Depends on: 1192372
|
|
Assignee | |
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1b51d0c353153f42c62b4e4ef6ca10fcd93c6f69 Bug 1201031 - Menu for conversation options in the panel should be under the arrow [r=andreio]
|
||
Updated•9 years ago
|
Iteration: --- → 43.2 - Sep 7
You need to log in
before you can comment on or make changes to this bug.
Description
•