1201079 - Stop appending a forward slash to every URL

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

Every URL has a superfluous forward slash shown in the address-bar.

Comment 1

[Richard Newman [:rnewman]]

This is because we dump the URL directly, which has the path. We might be able to simplify.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1046

This patch makes sure that we do not display a trailing slash for an `NSURL` that has an empty (`/`) or `nil` path component.

If the `NSURL` contains a non-empty path that ends with a trailing slash then we do not do anything. This is because that will actually result in a different URL. So for example `http://www.apple.com/iphone/` will not be changed. This is the same as *Firefox Desktop* handles it.

I have merged this logic in `absoluteStringWithoutHTTPScheme`, which is called by the `BrowserLocationView.updateTextWithURL()` to update the currently displayed URL. Because this now does more than just remove the `http://` part, I have renamed that function to `absoluteDisplayString`.

Also included tests to make sure this works on URLs with and without trailing slashes with both empty and non-empty path compoments.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8658422 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1046

LGTM

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8658422 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1046

LGTM

Comment 5

[Aaron Train [:aaronmt]]

Still see this on master (89db3d3)

Test URLs: aaronmt.com, polygon.com, ip9.com

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #5)
> Still see this on master (89db3d3)
> 
> Test URLs: aaronmt.com, polygon.com, ip9.com

Ok, just noticed this landed on 'v1.0'. I'll check back again.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1051

Same as https://github.com/mozilla/firefox-ios/pull/1046 but converted to Swift 2.0 for the master branch.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8658796 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1051

Usually safe to just land these uplifts without additional review (unless rebasing required significant changes).

Comment 9

[Aaron Train [:aaronmt]]

https://github.com/mozilla/firefox-ios/pull/1051 still not merged?

I see this on master still

Comment 10

[Brian Nicholson (:bnicholson)]

Thanks, merged https://github.com/mozilla/firefox-ios/commit/29fe5813819ea50251ad29e8bb4f0e7f95adae29.