1201081 - crash in java.lang.UnsupportedOperationException: at android.view.GLES20Canvas.clipPath(GLES20Canvas.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[u421692]

This bug was filed from the Socorro interface and is 
report bp-e99afd8c-9d3e-42a7-8abc-5adef2150902.
=============================================================
1. Open imdb.com

Result:
Firefox crashes

I was able to reproduce this only on one specific device Samsung Galaxy Tab 10.1 (Android 4.0.4); from what I see in the crash stats only device running API 15 are affected
See also bug 1198631

Comment 1

[Ioana Chiorean]

I am able to reproduce it also  on ZTE Grand X In ( Android 4.0.4) with the steps:
1) Go to http://mozilla.github.com/webrtc-landing/gum_test.html
2) Tap Audio & Video 

Note - this is an x86 device.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]:

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Nightly regression range. https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f384789a29dcfd514d25d4a16a97ec5309612d78&tochange=29b2df16e961fbe9a379362ecba6f888d1754bc3

Since this is doorhanger related it looks like bug 1193337. Crash only happens on API 15 devices. Margaret NI for an assignee.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Yep. 2b21997e3278 crashes and ff71dfc40c70 does not crash.

Comment 5

[:Margaret Leibovic]

Chenxia, can you look at this?

Comment 6

[Chenxia Liu [:liuche]]

Okay, I guess this means that clipPath might not be supported correctly even though it should go back to API 1.

Ugh, more reason to just switch to CardView instead of custom-bundling stuff.

Comment 7

[Chenxia Liu [:liuche]]

I'll look into bug 1203730, so we don't have to deal with regressions while doing clever, fun, tricksy things.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Is Fx42 affected? It looks like bug 1193337 was never uplifted to Fx42.

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

Double checked crash-stats, no crashes in 42. Given that I did not flag fx tracking I must have selected the wrong item from the drop down.

Comment 10

[:Margaret Leibovic]

However, we still have a problem, because bug 1193337 should have been uplifted to 42, and we should find a way to get that uplifted. (I would argue it's worth shipping the fix for bug 1193337, even if we don't have a fix here.)

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking this for now since it's a regression, though maybe the uplift in bug 1193337 will fix things.

Comment 12

[u421692]

Sign in on Sync.
Result: Firefox crashes
Tested on Samsung Galaxy Tab 10.1 (Android 4.0.4)

Comment 13

[:Margaret Leibovic]

Is there some sort of workaround we can use to catch this exception in RoundedCornerLayout and just end up with un-rounded corners instead of crashing?

Comment 14

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

Comment 15

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1201081 - Skip some code paths. r=sebastian

Bug 1201081 - Skip some code paths. r=sebastian

Comment 16

[Chenxia Liu [:liuche]]

The problem seems to be that on r11-18, clipPath will crash with hardware acceleration. I tried checking for hardware acceleration with canvas.isHardwareAccelerated(), as well as disabling hardware acceleration on those versions with setLayerType(SOFTWARE) but was still seeing crashes. So I'm just disabling this code path for r11-18.

Part 1 is just to avoid clipPath (which needs to be uplifted) and Part 2 is not doing the things that the clipPath approach does.

Real solution is just to use CardView, so I will look into that when I have time.

Also clearing tracking-42 because bug 1193337 has been uplifted to 42.

Comment 17

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8676481 [details]
MozReview Request: Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

https://reviewboard.mozilla.org/r/22723/#review20257

::: mobile/android/base/widget/RoundedCornerLayout.java:52
(Diff revision 1)
> +

NIT: Empty line?

Comment 18

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8676482 [details]
MozReview Request: Bug 1201081 - Skip some code paths. r=sebastian

https://reviewboard.mozilla.org/r/22725/#review20259

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0e8722f55ab9
https://hg.mozilla.org/integration/fx-team/rev/8917ec916bdd

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e8722f55ab9
https://hg.mozilla.org/mozilla-central/rev/8917ec916bdd

Comment 21

[Sylvestre Ledru [:Sylvestre]]

Chenxia, could you fill the uplift request to 43? Thanks

Comment 22

[Robert Kaiser]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:
It looks like a large amount of those crashes happen in 42.0b6 now, so requesting tracking there.

Comment 23

[Sylvestre Ledru [:Sylvestre]]

Chenxia: seems that we need it in beta too.
Tracking for 42 for obvious reasons.

Comment 24

[u421692]

Seems that this affects every device running API 15. 
As mentioned above, this issue reproduces on every site that has a doorhanger.

Comment 25

[Ioana Chiorean]

We verified that the Nightly landed patch fixed the crashes both on the tablet - Samsung Galaxy Tab 10.1 (Android 4.0.4) - and x86 device - Grand x In ( both are API 15).

Comment 26

[Chenxia Liu [:liuche]]

Comment on attachment 8676481 [details]
MozReview Request: Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: bug 1193337
[User impact if declined]: Crashes when doorhanger shows
[Describe test coverage new/current, TreeHerder]: local testing, baked on nightly
[Risks and why]: low, removing code paths
[String/UUID change made/needed]: none

Comment 27

[Chenxia Liu [:liuche]]

Comment on attachment 8676481 [details]
MozReview Request: Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

[Feature/regressing bug #]: bug 1193337
[User impact if declined]: Crashes when doorhanger shows
[Describe test coverage new/current, TreeHerder]: local testing, baked on nightly
[Risks and why]: low, removing code paths
[String/UUID change made/needed]: none

Comment 28

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8676481 [details]
MozReview Request: Bug 1201081 - UnsupportedOperationException crash at Canvas.clipPath. r=sebastian

Verified, fix a crash, taking it.
Should be in beta 10.

Comment 29

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d67b3103558a
https://hg.mozilla.org/releases/mozilla-aurora/rev/53f472c13242

Comment 30

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/45403faf67cf
https://hg.mozilla.org/releases/mozilla-beta/rev/13d1f4216f93

Comment 31

[Flaviu Cos]

Verified as fixed in Firefox 42 Beta 10;
Device: Asus Transformer Pad (Android 4.0.3).

Comment 32

[Flaviu Cos]

Verified as fixed in Firefox 43 Beta 1;
Device: Asus Transformer Pad (Android 4.0.3).