1201135 - Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

These names are a relic of the C origin of this file. The include guards would also need to be updated.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

mccr8, your reward for filing this bug is that you get to do the review :)

Comment 2

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a2c6489db93

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Comment on attachment 8661617 [details] [diff] [review]
Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

Review of attachment 8661617 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this! This has been a constant minor annoyance for me.

::: xpcom/glue/PLDHashTable.h
@@ +3,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef PLDHashTable_h___

Please remove the trailing underscores in PLDHashTable_h___ per the Mozilla style guide.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/895c0969f99e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/895c0969f99e