Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

RESOLVED FIXED in Firefox 43

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: njn)

Tracking

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
These names are a relic of the C origin of this file. The include guards would also need to be updated.
(Assignee)

Comment 1

2 years ago
Created attachment 8661617 [details] [diff] [review]
Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

mccr8, your reward for filing this bug is that you get to do the review :)
Attachment #8661617 - Flags: review?(continuation)
(Assignee)

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a2c6489db93
(Assignee)

Updated

2 years ago
Blocks: 1205183
(Assignee)

Updated

2 years ago
No longer blocks: 1205183
(Reporter)

Comment 3

2 years ago
Comment on attachment 8661617 [details] [diff] [review]
Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}

Review of attachment 8661617 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this! This has been a constant minor annoyance for me.

::: xpcom/glue/PLDHashTable.h
@@ +3,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef PLDHashTable_h___

Please remove the trailing underscores in PLDHashTable_h___ per the Mozilla style guide.
Attachment #8661617 - Flags: review?(continuation) → review+

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/895c0969f99e
(Assignee)

Updated

2 years ago
Blocks: 1205538
https://hg.mozilla.org/mozilla-central/rev/895c0969f99e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1229238
No longer depends on: 1229238
You need to log in before you can comment on or make changes to this bug.