1201137 - [New Homescreen] When dragging icons on the new homescreen, homescreen doesn't reposition the other icons to give the user a preview

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. set homescreens to new home screen
2. hit home
3. long tap on an icon and move the icon over other icons

Expected: other icons move to give you a preview
Actual: the other icons don't move.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1201137-new-homescreen-dragging-feedback > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8657846 [details] [review]
[gaia] Cwiiis:bug1201137-new-homescreen-dragging-feedback > mozilla-b2g:master

This implements Eric's idea of having icons move slightly out of the way in the direction that they'd go after rearranging (which I think looks and feels quite nice vs. having the whole container rearrange).

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8657846 [details] [review]
[gaia] Cwiiis:bug1201137-new-homescreen-dragging-feedback > mozilla-b2g:master

LGTM but I left a small question in Github. Also, there are no tests for this feature. Will you add some in a following patch?

Comment 4

[Chris Lord [:cwiiis]]

(In reply to Guillaume Marty [:gmarty] from comment #3)
> Comment on attachment 8657846 [details] [review]
> [gaia] Cwiiis:bug1201137-new-homescreen-dragging-feedback >
> mozilla-b2g:master
> 
> LGTM but I left a small question in Github. Also, there are no tests for
> this feature. Will you add some in a following patch?

Good call, I'll see about adding integration tests for this. Also answered question on Github.

Comment 5

[Chris Lord [:cwiiis]]

Marionette test added and merged: https://github.com/mozilla-b2g/gaia/commit/2b46a6f8c60f4c87b26a8cd0d65567fd2be8fa3d

Comment 6

[Chris Lord [:cwiiis]]

The performance of this was great when I committed it, but after updating Gecko, isn't really acceptable... I'll revisit this a bit further down the line.