1201181 - Add "Set a Homepage" item in Settings > Customize > Home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_set_dialog1.png

We'll need an item in Settings to allow our users the ability to set/edit their "Homepage" URL.

This will be in Settings > Customize > Home. We can add this underneath the "Panels" list. 

Title: Homepage
Subtitle (disabled): Set a link as your Homepage
Subtitle (enabled): *URL*

On press, let's use the simple dialog UI. I've attached a mock for what to include and what not. I think our most similar UI is currently in Chenxia's manual save for our logins work.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

NI-ing Martyn here to update the copy in his build :)

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Note: this just uses default styles from the Android L theme for now -we probably should not be creating anything new here. We can expand to a full page form if we decide to add more functionality later.

Changing me mind about the subtitle... 

Title: Set a Homepage 
Subtitle: About:home
Subtitle (enabled): URL (Martyn can we do this? I think we had issues before especially factoring in backwards compat issues, LMK)

Comment 3

[Martyn Haigh (:mhaigh)]

The new build for this piece of work is here: https://dl.dropboxusercontent.com/u/7163922/Work/1195721.apk

Everything should be to spec.  I've not tested on older devices yet, but I have the dynamic subtitle working on my current test device.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Looking good! 

Can we get the keyboard to trigger as well when the dialog is launched? It feels weird having to press again to select the input field in the dialog.

Comment 5

[Martyn Haigh (:mhaigh)]

Agreed - I've also set it so that the text is selected for the same reasons.  Same link: https://dl.dropboxusercontent.com/u/7163922/Work/1195721.apk

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Looks good!

Comment 7

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1201181 - Add Set a Homepage item in Settings - Customize - Home; r?mfinkle

Bug 1201181 - Add Set a Homepage item in Settings - Customize -  Home; r?mfinkle

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8660626 [details]
MozReview Request: Bug 1201181 - Add Set a Homepage item in Settings - Customize -  Home; r?mfinkle

https://reviewboard.mozilla.org/r/19151/#review17007

::: mobile/android/base/preferences/SetHomepagePreference.java:40
(Diff revision 1)
> +        builder.setInverseBackgroundForced(true);

I'm assuming we really want to do this.

Comment 9

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/9212e656007346226fea7f34c5c28c59d2bdb3f0
Bug 1201181 - Add "Set a Homepage" item in Settings > Customize > Home; r=mfinkle

Comment 10

[Martyn Haigh (:mhaigh)]

> 
> ::: mobile/android/base/preferences/SetHomepagePreference.java:40
> (Diff revision 1)
> > +        builder.setInverseBackgroundForced(true);
> 
> I'm assuming we really want to do this.

Yes - on GB devices the background was black.  Setting this makes it inline with other styles in the app and has no affect on later OS releases.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9212e6560073

Comment 12

[u549602]

Verified as fixed on latest Nightly on both Pad and phone devices.
The new home page that is set is displayed only after a browser restart