Closed Bug 1201214 Opened 9 years ago Closed 4 years ago

Handle return values of FallibleTArray functions in dom/svg/

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox43 --- wontfix
firefox80 --- fixed

People

(Reporter: mccr8, Assigned: longsonr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are a few of these in dom/svg. Ideally, we'd check the return value. What should be done for these?

3 AppendElement calls in SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromBasicAttrs:

SVGMotionSMILAnimationFunction.cpp:177
SVGMotionSMILAnimationFunction.cpp:185
SVGMotionSMILAnimationFunction.cpp:203

1 AppendElement call in SVGTransformListSMILType::GetTransforms:

SVGTransformListSMILType.cpp:366
jwatt, maybe you have some idea what should be done for these calls? Thanks.
Flags: needinfo?(jwatt)
I guess there's no particular hurry on this. There are probably a huge number of AppendElement calls that don't check their return value.
Flags: needinfo?(jwatt)
Blocks: 1201643
No longer blocks: 968520

Fortunately bug 1631371 has marked the methods and SVGPathData::GetSegmentLengths is dead code

Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/83984c20e08c
Deal with AppendElement failing if it's called in a fallible way r=jwatt
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: