Handle return values of FallibleTArray functions in dom/svg/

NEW
Unassigned

Status

()

Core
SVG
3 years ago
3 years ago

People

(Reporter: mccr8, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

(Reporter)

Description

3 years ago
There are a few of these in dom/svg. Ideally, we'd check the return value. What should be done for these?

3 AppendElement calls in SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromBasicAttrs:

SVGMotionSMILAnimationFunction.cpp:177
SVGMotionSMILAnimationFunction.cpp:185
SVGMotionSMILAnimationFunction.cpp:203

1 AppendElement call in SVGTransformListSMILType::GetTransforms:

SVGTransformListSMILType.cpp:366
(Reporter)

Comment 1

3 years ago
jwatt, maybe you have some idea what should be done for these calls? Thanks.
Flags: needinfo?(jwatt)
(Reporter)

Comment 2

3 years ago
I guess there's no particular hurry on this. There are probably a huge number of AppendElement calls that don't check their return value.
Flags: needinfo?(jwatt)
(Reporter)

Updated

3 years ago
Blocks: 1201643
No longer blocks: 968520
You need to log in before you can comment on or make changes to this bug.