1201303 - Create a tree widget for displaying census information

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1201303-heap-widget.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c97bf273bba

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8656791 [details] [diff] [review]
1201303-heap-widget.patch

Review of attachment 8656791 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/memory/modules/census-view.js
@@ +22,5 @@
> + * parent node is used for all rows.
> + *
> + * @param CensusView caller
> + *        The CensusView considered the "caller" frame. This newly created
> + *        instance will be represent the "callee". Should be null for root nodes.

There are no calls happening here, let's replace caller/callee with parent/child.

@@ +24,5 @@
> + * @param CensusView caller
> + *        The CensusView considered the "caller" frame. This newly created
> + *        instance will be represent the "callee". Should be null for root nodes.
> + * @param {Object} Report
> + *        An object containing definition describing the type of data in the report.

Based on the description, this should be "breakdown" not "report". The breakdown describes the structure, the report is the value generated by the census which has the structure described by a breakdown.

@@ +30,5 @@
> + *        Data from `takeCensus` transformed via `CensusTreeNode`. Data looks like:
> + *        Array<CensusViewData> children
> + *        String name
> + *        Number count
> + *        Bytes count

No need to describe a CensusTreeNode's structure here since that is already done for the CensusTreeNode docs. Add an @see path/to/CensusTreeNode.js if you want.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c3ff619131b4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3ff619131b4