1201431 - [sync] Add support for removing files from VCS

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Matjaz Horvat [:mathjazz]]

In vcs.py, we only add new and modify existing files on commit/push. We should also remove all missing files.

This is required for asymmetric formats where files can get obsolete.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/2892c36b378f7f6ef58803e72adfe57953cc23b6
Bug 1201431: remove missing files & folders from HG

https://github.com/mozilla/pontoon/commit/4cda77addade52b0319a7f427096053309cc5655
Merge pull request #243 from mathjazz/bug-1201431-remove-missing-from-vcs

Bug 1201431: remove missing files & folders from HG

Comment 2

[Matjaz Horvat [:mathjazz]]

Our VCS interface is now capable of removing files.

We need to modify sync so that it removes obsolete files from the filesystem (before pushing to VCS).

Comment 3

[Axel Hecht [:Pike]]

What's the next steps here?

Comment 4

[Matjaz Horvat [:mathjazz]]

We can detect deleted files during sync_project:
https://github.com/mozilla/pontoon/blob/master/pontoon/sync/core.py#L96

Next, we need to bring that list to sync_project_repo, maybe like this:
https://github.com/mozilla/pontoon/blob/master/pontoon/sync/tasks.py#L72

And then finally, we need to delete these files from the filesystem.

Also make sure locales_to_commit is set properly:
https://github.com/mozilla/pontoon/blob/master/pontoon/sync/changeset.py#L117

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/5dbb78bfbcb4cd17cac801bc521d45b6c2934117
Fix bug 1201431. Remove the obsolete resources.

https://github.com/mozilla/pontoon/commit/1333dd510c70bd5860a3a8a58c4bf88c0d83e2d4
Merge pull request #370 from jotes/bug_1201431_remove_obsolete_files

Fix bug 1201431. Remove the obsolete resources.