Disallow asm.js compilation for classes/methods

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: anba, Assigned: bbouvier)

Tracking

(Blocks: 1 bug)

Trunk
mozilla44
Points:
---

Firefox Tracking Flags

(firefox43 affected, firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Test case 1:
---
var c = class { constructor(stdlib, foreign, heap) { "use asm"; return {}; } };
c();
---

Expected: Throws TypeError
Actual: No TypeError



Test case 2:
---
var obj = ({m(stdlib, foreign, heap) { "use asm"; return {}; }});
new obj.m;
---

Expected: Throws TypeError
Actual: No TypeError
(Reporter)

Updated

3 years ago
Blocks: 837314
(Assignee)

Comment 1

3 years ago
Created attachment 8674813 [details] [diff] [review]
disable-asmjs-compilation-methods.patch

This blocks compilation when establishing preconditions. An alternative would be to allow compiling asm.js methods and checking in LinkAsmJS, but so far we've kept it simple and disallowed compilation for generators and arrow functions. So let's keep it that way.
Assignee: nobody → benj
Status: NEW → ASSIGNED
Attachment #8674813 - Flags: review?(luke)

Updated

3 years ago
Attachment #8674813 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/670b49ddf4e5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.