Closed
Bug 1201515
Opened 10 years ago
Closed 10 years ago
Avoid storing local visits into History while browsing in a private tab
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.1+ | --- |
| fxios-v1.0 | --- | unaffected |
| fxios-v1.0.5 | --- | unaffected |
People
(Reporter: sleroux, Assigned: sleroux)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently we fire off a LocationChange NSNotification from the BVC that signals the profile to store the visit into our database for history and in turn top sites. We need to ignore saving local visits to our history when surfing in private mode.
Code in question: https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L1459
https://github.com/mozilla/firefox-ios/blob/master/Providers/Profile.swift#L211
|
||
Comment 1•10 years ago
|
||
Tracking 'cos PB is tracking.
status-fxios-v1.0:
--- → unaffected
status-fxios-v1.0.5:
--- → unaffected
tracking-fxios:
--- → 1.1+
Hardware: Other → All
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sleroux
|
|
Assignee | |
Comment 2•10 years ago
|
||
First patch for PBMode!
Attachment #8657122 -
Flags: review?(bnicholson)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8657122 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1035
Nice, looks good. Several questions in the PR, but nothing major.
Attachment #8657122 -
Flags: review?(bnicholson) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Merged
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•10 years ago
|
||
Verifying as fixed on current TestFlight build (1104)
The page visited in private browsing are not saved in History
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•