1201576 - Intermittent double reconnects on waking from hibernation

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

I've only seen this behaviour for IRC.

Comment 1

[aleth [:aleth]]

Attachment: clearquittimer.diff

This happens when disconnect() is called on wake before the wake notification observer calls gotDisconnected() to timeout the dead connection. disconnect() tries to send QUIT and sets a quit timer. By the time the quit timer fires, the account is already reconnected, and so gets disconnected again.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8656657 [details] [diff] [review]
clearquittimer.diff

Review of attachment 8656657 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/ircBase.jsm
@@ -169,5 @@
>        else {
>          // We received an ERROR message when expecting it (i.e. we've sent a
> -        // QUIT command).
> -        clearTimeout(this._quitTimer);
> -        delete this._quitTimer;

Why adding these here too? You call gotDisconnected right after this.

Comment 3

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #2)
> > -        clearTimeout(this._quitTimer);
> > -        delete this._quitTimer;
> 
> Why adding these here too? You call gotDisconnected right after this.

If you look closely, you'll see it's a -, not a + in the left hand column ;)

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8656657 [details] [diff] [review]
clearquittimer.diff

Review of attachment 8656657 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I read a diff backward.

This looks good!

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4daeea0130fbe7385754aa7a36c8f7b0189fb800
Bug 1201576 - Make sure the quit timer is reset on disconnection to avoid double reconnects. r=clokep