1201581 - Fixed-position margins/clip are not updated properly in fennec-apz

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR:
1. Start a fennec built with --enable-android-apz
2. Load the page at http://people.mozilla.org/~kgupta/bug/1180295.html
3. Put your finger down on the page and scroll downwards slowly

Expected;
As the toolbar slides off the page, the green fixed-pos box at the bottom of the screen should stay stuck to the bottom of the screen

Actual:
It drifts up and there is a white band at the bottom of the screen

This is happening because we're not syncing the FrameMetrics to the ImmutableViewportMetrics per composite like we should be doing. There is a comment to this effect at http://mxr.mozilla.org/mozilla-central/source/gfx/layers/composite/AsyncCompositionManager.cpp?rev=4c8fcc50b299#645 although it's a little out of date.

We do need some sort of syncing code there, although I need to figure out exactly which data needs to be sent from C++ -> Java and which data needs to be sent from Java -> C++

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP

This makes the fix-pos box stick to the bottom, but the clipping is still not right. I might need to adjust the clip on a different layer. However I'm PTO in the afternoon so stashing this patch here for now.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Extract a helper method

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Hook up the syncFrameMetrics call

This fixes the issues described in comment 0, by making sure the metrics information are synced between Java and C++ on each composite.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8657185 [details] [diff] [review]
Part 2 - Hook up the syncFrameMetrics call

Oh wait I screwed up this patch. It should be using mViewportMetrics and not mFrameMetrics. Let me re-test.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Hook up the syncFrameMetrics call

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Try push including these patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bf75164c069

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Extract a helper method

Rebased, carrying r+

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18f719dfea70
https://hg.mozilla.org/integration/mozilla-inbound/rev/6300571e5c68

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18f719dfea70
https://hg.mozilla.org/mozilla-central/rev/6300571e5c68