Closed
Bug 1201626
Opened 9 years ago
Closed 9 years ago
Remove reference to "kind" attribute since it's not used anymore in isExplicitInPermissionsTable
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: arroway, Assigned: arroway)
Details
Attachments
(1 file, 1 obsolete file)
"kind" attribute was called to identify trusted hosted apps. It's still passed as arguments in several functions such as isExplicitInPermissionsTable, but it's not used in the code.
Assignee | ||
Comment 1•9 years ago
|
||
This patch removes the calls of the attribute appKind which is unused when calling function passing it as an argument to isExplicitInPermissionsTable().
Attachment #8661401 -
Flags: review?(fabrice)
Comment 2•9 years ago
|
||
Comment on attachment 8661401 [details] [diff] [review] Bug-1201626-Remove-reference-to-kind-attribute-to-ca.patch Review of attachment 8661401 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: dom/permission/PermissionSettings.js @@ +71,4 @@ > .createCodebasePrincipal(uri, {appId: app.localId, inBrowser: aBrowserFlag}); > > return isExplicitInPermissionsTable(aPermName, > + principal.appStatus); nit: that should fit on a single line now.
Attachment #8661401 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Uploaded patch with updated commit message and run tests on try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c0812d781a1, failures seems to be know intermittent failing tests.
Attachment #8661401 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → stephouillon
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6284099120ad
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•