1201626 - Remove reference to "kind" attribute since it's not used anymore in isExplicitInPermissionsTable

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Stephanie Ouillon [:arroway] (needinfo me)]

"kind" attribute was called to identify trusted hosted apps. It's still passed as arguments in several functions such as isExplicitInPermissionsTable, but it's not used in the code.

Comment 1

[Stephanie Ouillon [:arroway] (needinfo me)]

Attachment: Bug-1201626-Remove-reference-to-kind-attribute-to-ca.patch

This patch  removes the calls of the attribute appKind which is unused when calling function passing it as an argument to isExplicitInPermissionsTable().

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8661401 [details] [diff] [review]
Bug-1201626-Remove-reference-to-kind-attribute-to-ca.patch

Review of attachment 8661401 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: dom/permission/PermissionSettings.js
@@ +71,4 @@
>        .createCodebasePrincipal(uri, {appId: app.localId, inBrowser: aBrowserFlag});
>  
>      return isExplicitInPermissionsTable(aPermName,
> +                                        principal.appStatus);

nit: that should fit on a single line now.

Comment 3

[Stephanie Ouillon [:arroway] (needinfo me)]

Attachment: 0001-Bug-1201626-Remove-reference-to-kind-attribute-to-ca.patch

Uploaded patch with updated commit message and run tests on try server
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c0812d781a1, failures seems to be know intermittent failing tests.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6284099120ad

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6284099120ad