1201715 - Ensure to wait up to 30s for remote page loads

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A couple of our Firefox UI tests are currently failing because loading remote sites will take longer than the default 5s from the Wait() call. Means we have to add a timeout of 30s to it, which should really be enough.

Once landed the change should fix a couple of current timeout failures. I will add them as dependency to this bug.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: github_pull_request.txt

This PR might fix some of the intermittent failures we see in remote tests.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed Pr on master:
https://github.com/mozilla/firefox-ui-tests/commit/6d6d57917f85399e903ac69b7e4297091b2d474c

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://github.com/mozilla/firefox-ui-tests/commit/5995adf5cf12610bd8538824f0ea60079cd0aeeb (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/c9837f1ac967221ba69421caebf0f6c4b9ba5ccf (beta)

We don't seem to have those issues for releases yet. Also given that it would need some extra work for the backports to mozilla-release and mozilla-esr38 I will mark them as wontfix for now. We can reconsider backporting the patch further if there is clearly a need for.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

esr38 will still exist for a while. It would be better to also fix it for that branch. The failure rate is low at the moment but it should be worth it. I will have a look at the backport soonish.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The backport is hard because the patch on bug 1145112 never landed on the mozilla-esr38 branch. I will check that other bug for a backport first.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

After the other backport has been landed this one went without merge conflicts:

https://github.com/mozilla/firefox-ui-tests/commit/634c08a6b58c274ef30ded286e2a941ed3170f56 (esr38)