Move jit/XXX/BaselineIC-XXX.cpp to jit/XXX/SharedIC-XXX.cpp

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

4 years ago
Unary and binary arith have code in the baselineIC, but are already moved to sharedIC. Move the platform specific code also to such a file.
Assignee

Updated

4 years ago
Blocks: 1161516
Assignee

Comment 1

4 years ago
Very small change
Assignee: nobody → hv1989
Attachment #8657117 - Flags: review?(jdemooij)
Assignee

Comment 2

4 years ago
Posted patch Actual patchSplinter Review
Attachment #8657125 - Flags: review?(jdemooij)
Comment on attachment 8657117 [details] [diff] [review]
Part 0: Make x86/x64 a bit more similar

Review of attachment 8657117 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/x64/SharedICHelpers-x64.h
@@ +95,5 @@
>  EmitIonTailCallVM(JitCode* target, MacroAssembler& masm, uint32_t stackSize)
>  {
>      ScratchRegisterScope scratch(masm);
>  
> +    masm.loadPtr(Address(esp, stackSize), eax);

I think this should be `scratch` instead of eax, as it was before.

::: js/src/jit/x86/SharedICHelpers-x86.h
@@ +94,5 @@
>  
>  inline void
>  EmitIonTailCallVM(JitCode* target, MacroAssembler& masm, uint32_t stackSize)
>  {
> +    // For tail calls, find the already pushed JitFrame_IonJS signifying the

Shouldn't we add this comment to the x64 code as well?
Attachment #8657117 - Flags: review?(jdemooij) → review+
Comment on attachment 8657125 [details] [diff] [review]
Actual patch

Review of attachment 8657125 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/moz.build
@@ +396,5 @@
>              'jit/x64/Assembler-x64.cpp',
>              'jit/x64/Bailouts-x64.cpp',
>              'jit/x64/BaselineCompiler-x64.cpp',
>              'jit/x64/BaselineIC-x64.cpp',
> +            'jit/x64/SharedIC-x64.cpp',

I'd add it between MacroAssembler-x64 and Trampoline-x64 to keep the list sorted, same below.
Attachment #8657125 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/01324f0b7651
https://hg.mozilla.org/mozilla-central/rev/8d7edac29dad
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.