1201868 - Turn on assembler optimization for OSX x86_64

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Makoto Kato [:m_kato]]

We still use C language code only for OSX x86_64...  We should use assembler code for MPI and Intel AES.   But toolchain is old on OSX, so we cannot still use AES GCM code.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Use assembler for some code

asm suffix is ".s", we cannot use macro.  So I add fixed copy for OSX.

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8657087 [details] [diff] [review]
Use assembler for some code

asm suffix is ".s", so we cannot use #ifdef macro into assmbler code.   So I add darwin's assembler.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8657087 [details] [diff] [review]
Use assembler for some code

wtc, could you review instead of Robert?

Comment 4

[Wan-Teh Chang]

Makoto: could you provide either a reference or an example in the Mozilla
source tree that shows the differences between the Linux and Mac OS X
assemblers that your patch handles?

- the need for the leading underscore in function names
- the need to delete .type, .size, .section, and .previous directives

Thanks!

Comment 5

[Wan-Teh Chang]

Makoto: should we rename these files with the .S (capital S) suffix
so that we can use C preprocessor macros in these files?

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Wan-Teh Chang from comment #4)
> Makoto: could you provide either a reference or an example in the Mozilla
> source tree that shows the differences between the Linux and Mac OS X
> assemblers that your patch handles?
> 
> - the need for the leading underscore in function names
> - the need to delete .type, .size, .section, and .previous directives
> 
> Thanks!

Apple's assembler doesn't support it.  Bug 333601 comment #1 and landing code are answer.


(In reply to Wan-Teh Chang from comment #5)
> Makoto: should we rename these files with the .S (capital S) suffix
> so that we can use C preprocessor macros in these files?

NSS build config doesn't support .S file for preprocessor.