Closed Bug 1201907 Opened 4 years ago Closed 4 years ago

Enable memory tool for production

Categories

(DevTools :: Memory, defect)

41 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 44

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

This enables the memory tool -- this needs to land after Fx43 is merged up so Fx43 targets do not support memory tool.
Summary: Add `memoryTool` trait on root actor for Fx44+ → Add `heapSnapshots` trait on root actor for Fx44+
This should also remove any of the magic behind devtools.memory.enabled so it's a normal tool pref like the other ones.
Summary: Add `heapSnapshots` trait on root actor for Fx44+ → Enable memory tool for production
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8680216 - Flags: review?(nfitzgerald)
Comment on attachment 8680216 [details] [diff] [review]
1201907-enable-mem.patch

Review of attachment 8680216 [details] [diff] [review]:
-----------------------------------------------------------------

Woo! \o/
Attachment #8680216 - Flags: review?(nfitzgerald) → review+
I had to back this out so I could cleanly back out bug 1217946 for bustage: https://hg.mozilla.org/integration/fx-team/rev/b1619ee272b6
Flags: needinfo?(jsantell)
Thanks Wes
Flags: needinfo?(jsantell)
This landed yesterday - https://hg.mozilla.org/mozilla-central/rev/601528a16cf9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.