1201951 - Use "nice" slugids in taskcluster payloads

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Pete Moore [:pmoore][:pete]]

For context, see bug 1194767.

This change prevents slugids being created in taskcluster payload definitions that begin with a '-' character, which can cause problems for tools (downstream) that use the slugids as command line parameters.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] petemoore:bug1201951 > mozilla-b2g:master

Comment 2

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8657220 [details] [review]
[gaia] petemoore:bug1201951 > mozilla-b2g:master

Thanks guys!

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8657220 [details] [review]
[gaia] petemoore:bug1201951 > mozilla-b2g:master

Looks good to me... minor comment, optional if you want to address it.
Just a suggestion...

Comment 4

[Aus Lacroix [:aus]]

Comment on attachment 8657220 [details] [review]
[gaia] petemoore:bug1201951 > mozilla-b2g:master

This looks good to me as well, some feedback in github PR.

Comment 5

[Pete Moore [:pmoore][:pete]]

Thanks guys! I've incorporated your feedback, feel free to take a look again. If you are happy with it, please feel free to land it (I don't think I have permission).

Thanks!

Comment 6

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/4b6903bd8d1629346bb0c7ec9bafba37ce500dca

Comment 7

[Pete Moore [:pmoore][:pete]]

Thanks Tomcat! =)