1202092 - Use iOS 9 APIs for clearing private data

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Some of the clear private data techniques we use are hacks. iOS 9 gives more control over the data; we should take advantage of those new APIs.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1063

Updated Clear Private Data tests coming in bug 1170690.

Comment 2

[Brian Nicholson (:bnicholson)]

After testing the equivalent History > Clear Recent History... on desktop, I found that localStorage/sessionStorage are cleared in Cookies, *not* Offline Website Data as expected. I think we should consider merging these it's not obvious which settings clear which items, and most users won't know the difference anyway.

Darrin/Robin, what do you think? FWIW, Chrome has a single pref for all cookies and storage: "Cookies and other site and plugin data".

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8660152 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1063

LGTM

Comment 4

[Brian Nicholson (:bnicholson)]

Going to land as-is; we can file a follow-up if UX finds anything that needs tweaking.

https://github.com/mozilla/firefox-ios/commit/5f0b4ba53de0fd16f08b56dbd2f5143d8610e8d7