Closed
Bug 1202093
Opened 9 years ago
Closed 9 years ago
Confirmation UI for clearing private data
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.1+ | --- |
| fxios-v1.1 | --- | fixed |
| fxios-v1.0.5 | --- | unaffected |
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
sleroux
:
review+
tecgirl
:
ui-review+
|
Details | Review |
We should have some kind of toast/alert before or after clearing private data just to confirm the user action.
|
Assignee | |
Comment 1•9 years ago
|
||
One existing example on iOS: Settings > Safari > Advanced > Website Data > Remove All Website Data. That triggers the following alert, which the user has to confirm again before the deletion: https://www.dropbox.com/s/yfavhe2f16j9lo1/Screenshot%202015-09-09%2008.48.15.png?dl=0
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(randersen)
Flags: needinfo?(dhenein)
|
|
Assignee | |
Comment 2•9 years ago
|
||
The plan is to just switch the Clear Private Button to disabled after tapping it. We'll no longer automatically kick the user back to Settings.
Flags: needinfo?(randersen)
Flags: needinfo?(dhenein)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Robin, how does this feel to you?
Attachment #8658909 -
Flags: ui-review?(randersen)
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(dhenein)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8658909 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1052
Darrin's fine with landing these now and filing separate follow-ups if needed after UX review.
Attachment #8658909 -
Flags: review?(sleroux)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8658909 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1052
LGTM - Just a question about the assert
Attachment #8658909 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
status-fxios-v1.0.5:
--- → unaffected
status-fxios-v1.1:
--- → fixed
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Attachment #8658909 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(dhenein)
You need to log in
before you can comment on or make changes to this bug.
Description
•