1202154 - Switchboard does not catch Locale related exceptions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Both Locale.getISO3Language and Locale.getISO3Country can throw MissingResourceException exceptions. I see a few in crash-stats already.

Comment 1

[Richard Newman [:rnewman]]

Consider using o.m.g.Locales.getLanguageTag() or friends instead, if we're forking the client codebase.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: switchboard-locale-crashfix v0.1

This patch wraps the calls and falls back to "unknown" in cases of exceptions.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #1)
> Consider using o.m.g.Locales.getLanguageTag() or friends instead, if we're
> forking the client codebase.

I wouldn't use it directly yet, but we could consider using the basics. It would change the code sent to the server, but we are not using that yet for anything. If we decide to use Switchboard for iOS, it would be nice to have consistent language and country codes being sent up from each platform.

Comment 4

[Richard Newman [:rnewman]]

zz_ZZ is Accented English, a developer option. Switchboard should recognize that and return a sentinel rather than just muffling; we know it's English, not Unknown. Alternatively, we could treat this as en_US.

ja_JA is just wrong; it should be ja_JP, in which case the 3-letter country code will be "JPN". This sounds like a really broken device. The crash reports say it's an iNet ADP-921, which is an el cheapo $75 9" tablet sold at Japanese grocery stores, so I bet it's a typo from the OEM when they hard-coded the firmware to Japanese….

I'm not opposed to introducing a correction step here; we'll need to do so for our strings and other reporting to work correctly anyway.

Comment 5

[Nick Alexander :nalexander [he/him]]

I'm late to this party, but it appears to me:

* We should specifically handle zz_ZZ, since it's an Android-ism that java.utils.getISO3* won't handle and it has a clear interpretation.

* We do need to catch some exceptions.

It's not clear that we should go all the way to replacing Switchboard's language codes with Fennec's.  It stands to reason that Switchboard Android and iOS agree right now, where-as Fennec and unmodified Switchboard iOS will not agree.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8657492 [details] [diff] [review]
switchboard-locale-crashfix v0.1

Review of attachment 8657492 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with this as is -- we're unlikely to see "unknown" frequently in the wild.  I'd prefer to catch zz_ZZ, for the reasons mentioned in my comment.  I think changing the code entirely is follow-up.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #4)
> zz_ZZ is Accented English, a developer option. Switchboard should recognize
> that and return a sentinel rather than just muffling; we know it's English,
> not Unknown. Alternatively, we could treat this as en_US.

(In reply to Nick Alexander :nalexander from comment #5)

> * We should specifically handle zz_ZZ, since it's an Android-ism that
> java.utils.getISO3* won't handle and it has a clear interpretation.

I also see mention of en_XA (adds glyphs & inflates length) and ar_XB (reverses every string and sets the locale to right-to-left). Given that these are developer options and not production options, I don't want to add anything just yet.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/da7ee978ac06

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da7ee978ac06