1202190 - [NewHomescreen]Cannot move an icon to make it become the last icon of last page.

Status: VERIFIED DUPLICATE of bug 1218329

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: logcat3.txt

[1.Description]:
[Aries][v2.5][NewHomescreen]Cannot move an icon to make it become the last icon of last page.
Found at:16:17
see attachment:logcat3.txt, AriesKK_V2.5.3GP.

[2.Testing Steps]: 
1. Move an app to make it become the last icon of last page.

[3.Expected Result]: 
1.Can move an icon to make it become the last icon of last page.

[4.Actual Result]: 
1.The icon cannot be moved.

[5.Reproduction build]: 
Device: Aries KK 2.5[Affected]
Build ID               20150901190039
Gaia Revision          c2582f4be03cd12124b96a263c8d14c774f0ffe4
Gaia Date              2015-09-01 17:03:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e47423c019643792e6de894cfcee598dead4d3ba
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150901.182105
Firmware Date          Tue Sep  1 18:21:13 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
16592

Comment 1

[Alissa（leave from Mozilla）]

Attachment: Flamekk_v2.5.3gp

Comment 2

[Chris Lord [:cwiiis]]

Seems to be the wrong video attached?

Comment 3

[Alissa（leave from Mozilla）]

Attachment: AriesKK_V2.5.3gp

Update attachment.

Comment 4

[Chris Lord [:cwiiis]]

Heh, this is something I fixed specifically before merging, I guess I must've broken it at some point... Will have to make sure this is tested when I fix it.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1202190-new-homescreen-drop-icon-at-end > mozilla-b2g:master

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 8657828 [details] [review]
[gaia] Cwiiis:bug1202190-new-homescreen-drop-icon-at-end > mozilla-b2g:master

Fixed regression, added unit tests to prevent it appearing again.

Comment 7

[Guillaume Marty [:gmarty]]

Comment on attachment 8657828 [details] [review]
[gaia] Cwiiis:bug1202190-new-homescreen-drop-icon-at-end > mozilla-b2g:master

LGTM with a nit/question left on GH.

Comment 8

[Chris Lord [:cwiiis]]

Fixed and merged, thanks: https://github.com/mozilla-b2g/gaia/commit/d068ae4d95a291396abd6ed40b8a125a9b5b5a51

Comment 9

[Alissa（leave from Mozilla）]

This issue has been verified as pass in latest build of AriesKK_V2.5
Rate:0/5

Device: AriesKK_V2.5[pass]
Build ID               20150909010407
Gaia Revision          e69f2c86b931b723dd405115e33a1d02e6c5f5e6
Gaia Date              2015-09-08 20:39:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/02b255caee93ac6fdfb2384ec90d748ab112ef27
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150909.002540
Firmware Date          Wed Sep  9 00:25:48 UTC 2015
Bootloader             s1

Comment 10

[Teri Wen [:twen]]

Found this issue again on the latest build.

Drag an app that is not in the last page will recreate this bug. App will become the first icon on top of the home screen instead of the last icon. 

[Build Info]
Build ID               20151025085903
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151025.081846
Firmware Date          Sun Oct 25 08:18:54 UTC 2015
Bootloader             s1

Comment 11

[Teri Wen [:twen]]

Nominate blocking for decision.

Comment 12

[Chris Lord [:cwiiis]]

This works for me on master - possibly you were encountering bug 1218329?

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Blocker if not a dupe.

Comment 14

[Alissa（leave from Mozilla）]

Hi chris,
I can reproduce this issue as Teri said: "Drag an app that is not in the last page will recreate this bug. App will become the first icon on top of the home screen instead of the last icon. "

Device:AriesKK_V2.5
Build ID               20151025150204
Gaia Revision          1c6628ed1e40575e5ec3669ab6ef389d4ebeea65
Gaia Date              2015-10-23 17:01:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d53a52b39a95dced722cca90ac74529b66dd5253
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151025.184556
Firmware Date          Sun Oct 25 18:46:08 EDT 2015
Bootloader             L1TC000118D0

Comment 15

[Chris Lord [:cwiiis]]

Could you provide a video of this issue? Either that, or *very* specific STR?

I can drag icons all over the place and not reproduce this. I can reproduce bug 1218329, but that will be fixed imminently.

Comment 16

[Teri Wen [:twen]]

This could be related to bug 1218329. Will check again after the fix has landed for that bug.

Comment 17

[Alissa（leave from Mozilla）]

Attachment: Arieskk_v2.5.3gp

Provide the video on aries.

Comment 18

[Chris Lord [:cwiiis]]

I think this will be fixed by bug 1218329, leaving for Teri to check as per comment #16.

Comment 19

[Teri Wen [:twen]]

Yep, verified fixed by bug 1218329. Thanks Chris and Alissa. 
Changing status back to verified.

Build ID               20151027221526
Gaia Revision          a26eadc5e1133d5112b6cbc10badbb7670a1090f
Gaia Date              2015-10-27 17:36:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b333a1d94e805a59c619ee41a6dec7fdcce505d
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151027.213419
Firmware Date          Tue Oct 27 21:34:27 UTC 2015
Bootloader             s1

Comment 20

[Teri Wen [:twen]]

Wrong status. 
Change to duplicate.