1202206 - The bottom tile row on the New Tab Page is truncated

Status: RESOLVED DUPLICATE of bug 1180387

(Firefox :: New Tab Page, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: new-tab-screenshot.jpg

[Tracking Requested - why for this release]:

This is a regression in Aurora 42 and Nightly 43 from bug 1180387.

Aurora 42 and Nightly 43 show three rows of tiles on the about:newtab page, but the bottom row is cut off. I am using a MacBook Pro with a 13" Retina display, which is pretty small and only two tile rows can fit without being cut off.

I bisected this regression to bug 1180387. Bug 1194895 fixed a related regression, where an extra row of empty tiles caused a vertical scroll bar, but in my user profile the tiles in the extra row are not empty.

Please see the attached screenshot.

Comment 1

[maxim zhilyaev]

Chris,

I am a bit confused about "the bottom row is cut off".  Do you mean that the third row is not fully visible?  Or do you mean that there's a forth row that you have expected to be accessible, but you can't scroll down to it, because we never show it?

Could you please clarify.

Comment 2

[maxim zhilyaev]

Chris,  also note that seeing a scroll bar when a bottom row does not completely fit into your view port and has non-empty tiles is actually the intended behavior that bug 1194895 introduced to address users' issues listed in 1180387.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to maxim zhilyaev from comment #1)
> I am a bit confused about "the bottom row is cut off".  Do you mean that the
> third row is not fully visible?  Or do you mean that there's a forth row
> that you have expected to be accessible, but you can't scroll down to it,
> because we never show it?

The third row is not fully visible. The attached screenshot has a picture. There is no fourth row.

Comment 4

[maxim zhilyaev]

(In reply to Chris Peterson [:cpeterson] from comment #3)

> The third row is not fully visible. The attached screenshot has a picture.
> There is no fourth row.

This is the expected behavior. If the row contains history tiles and does not fit into the screen, we show what's visible and place a scroll bar to access what's hidden.  
You can take a look at the cause of tile height increase: https://bugzilla.mozilla.org/show_bug.cgi?id=1180387#c24
and various decisions proposed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1180387#c32

Comment 5

[Chris Peterson [:cpeterson]]

OK. Thanks for the links to the design discussion in bug 1180387.